[jira] [Commented] (OAK-4898) Allow for external changes to have a CommitInfo attached

["Stefan Egli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668279#comment-15668279 ] 

Stefan Egli commented on OAK-4898:
----------------------------------

nice feature!
just 2 comments: the {{isExternal}} methods now still check for {{info == null}} even though we aim to no longer pass null for an external event, so we're covering the "other cases" for null there. Wondering what they are? The other comment is a bit similar, but in BackgroundObserver we know that when we collapse we explicitly make info == null - and yet the method says {{isExternal}} - perhaps we should rename it there to {{isExternalOrCompacted}} to make this clearer? (but then it's asymmetric wrt the other isExternals...

> Allow for external changes to have a CommitInfo attached
> --------------------------------------------------------
>
>                 Key: OAK-4898
>                 URL: https://issues.apache.org/jira/browse/OAK-4898
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.6
>
>         Attachments: OAK-4898-v1.patch
>
>
> Currently the observation logic relies on fact that CommitInfo being null means that changes are from other cluster node i.e. external changes. 
> We should change this semantic and provide a different way to indicate that changes are external. This would allow a NodeStore implementation to still pass in a CommitInfo which captures useful information about commit like brief summary on what got changed which can be used for pre filtering (OAK-4796)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)