You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 16:00:17 UTC
[GitHub] [incubator-nuttx] onegray opened a new pull request, #7418: boards/stm32wb: Flipper Zero initial support
onegray opened a new pull request, #7418:
URL: https://github.com/apache/incubator-nuttx/pull/7418
## Summary
This is an initial support of FlipperZero device. The device is developer-friendly - it has public hardware documentation, SWD pins for debugging, serial interface pins. See https://flipperzero.one for device details.
## Impact
None
## Testing
`nsh` configuration works properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7418: boards/stm32wb: Flipper Zero initial support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7418:
URL: https://github.com/apache/incubator-nuttx/pull/7418#issuecomment-1289968383
ci failure is fixed by:
https://github.com/apache/incubator-nuttx/pull/7422
let's merge this patch directly to save the server loading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7418: boards/stm32wb: Flipper Zero initial support
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7418:
URL: https://github.com/apache/incubator-nuttx/pull/7418#issuecomment-1289453145
Amazing @onegray !!! Please fix the incorrect path in this file:
```
Error: boards/arm/stm32wb/flipperzero/include/flipperzero-clocking.h:2:1: error: Relative file path does not match actual file
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7418: boards/stm32wb: Flipper Zero initial support
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7418:
URL: https://github.com/apache/incubator-nuttx/pull/7418#discussion_r1003590412
##########
boards/arm/stm32wb/flipperzero/include/board.h:
##########
@@ -0,0 +1,115 @@
+/****************************************************************************
+ * boards/arm/stm32wb/flipperzero/include/board.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_ARM_STM32WB_FLIPPERZERO_INCLUDE_BOARD_H
+#define __BOARDS_ARM_STM32WB_FLIPPERZERO_INCLUDE_BOARD_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#ifndef __ASSEMBLY__
+# include <stdint.h>
Review Comment:
```suggestion
# include <stdint.h>
```
##########
boards/arm/stm32wb/flipperzero/include/flipperzero-clocking.h:
##########
@@ -0,0 +1,262 @@
+/****************************************************************************
+ * boards/arm/stm32wb/flipperzero/include/flipperzero.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_ARM_STM32WB_FLIPPERZERO_INCLUDE_FLIPPERZERO_H
+#define __BOARDS_ARM_STM32WB_FLIPPERZERO_INCLUDE_FLIPPERZERO_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#ifndef __ASSEMBLY__
+# include <stdint.h>
Review Comment:
```suggestion
# include <stdint.h>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7418: boards/stm32wb: Flipper Zero initial support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7418:
URL: https://github.com/apache/incubator-nuttx/pull/7418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org