[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #1201: HDDS-3798. Display more accurate timestamp in recon Web

[GitBox <gi...@apache.org>]

vivekratnavel commented on a change in pull request #1201:
URL: https://github.com/apache/hadoop-ozone/pull/1201#discussion_r454789270



##########
File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
##########
@@ -197,7 +197,7 @@ const COLUMNS = [
     isVisible: false,
     sorter: (a: IDatanode, b: IDatanode) => a.setupTime - b.setupTime,
     render: (uptime: number) => {
-      return uptime > 0 ? moment(uptime).format('lll') : 'NA';
+      return uptime > 0 ? moment(uptime).format('YYYY/MM/DD HH:mm:ss') : 'NA';

Review comment:
       ```suggestion
         return uptime > 0 ? moment(uptime).format('ll LTS') : 'NA';
   ```

##########
File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
##########
@@ -135,7 +135,7 @@ const COLUMNS = [
     isVisible: true,
     sorter: (a: IDatanode, b: IDatanode) => a.lastHeartbeat - b.lastHeartbeat,
     render: (heartbeat: number) => {
-      return heartbeat > 0 ? moment(heartbeat).format('lll') : 'NA';
+      return heartbeat > 0 ? moment(heartbeat).format('YYYY/MM/DD HH:mm:ss') : 'NA';

Review comment:
       Can we use `ll LTS`?
   ```suggestion
         return heartbeat > 0 ? moment(heartbeat).format('ll LTS') : 'NA';
   ```

##########
File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx
##########
@@ -44,7 +44,7 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
         <Tooltip
           placement='bottom' title={moment(lastUpdated).format('lll')}

Review comment:
       Can we also update the tooltip to include seconds?
   ```suggestion
             placement='bottom' title={moment(lastUpdated).format('ll LTS')}
   ```

##########
File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/pipelines/pipelines.tsx
##########
@@ -114,7 +114,7 @@ const COLUMNS = [
     dataIndex: 'lastLeaderElection',
     key: 'lastLeaderElection',
     render: (lastLeaderElection: number) => lastLeaderElection > 0 ?
-      moment(lastLeaderElection).format('lll') : 'NA',
+      moment(lastLeaderElection).format('YYYY/MM/DD HH:mm:ss') : 'NA',

Review comment:
       ```suggestion
         moment(lastLeaderElection).format('ll LTS') : 'NA',
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org