You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/14 03:14:59 UTC
[GitHub] [superset] michellethomas opened a new issue #12509: Sqllab query max limit in query dropdown
michellethomas opened a new issue #12509:
URL: https://github.com/apache/superset/issues/12509
Hi, With the new updates to sqllab (🎉 ) it looks like the max limit in the `limit` dropdown in sqllab is 100,000. Previously, we had the SQL_MAX_ROW config setting to set the max limit on sql queries. Can we allow users to type in their own limit into the limit dropdown (up to `SQL_MAX_ROW`) or make the dropdown options configurable? It would be nice to have the option of getting more results in sqllab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12509:
URL: https://github.com/apache/superset/issues/12509#issuecomment-760460989
@yousoph
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12509:
URL: https://github.com/apache/superset/issues/12509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #12509:
URL: https://github.com/apache/superset/issues/12509#issuecomment-760456423
We should replace that dropdown with a `CreatableSelect` (or set `mode="tags"` if using AntD select).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #12509:
URL: https://github.com/apache/superset/issues/12509#issuecomment-760550764
Immediate solution: Show additional options in the LIMIT dropdown based on SQL_MAX_ROW
If needed, users can customize to a different LIMIT in the query itself
That should solve the most pressing issue but let us know if it doesn't
Also open to exploring a more configurable dropdown in the future if the above doesn't meet user's needs. (I'm always happy to chatting about problems / pain points / use cases if anybody has thoughts! 😄 )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #12509:
URL: https://github.com/apache/superset/issues/12509#issuecomment-760456423
We should replace that dropdown with a `CreatableSelect`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michellethomas commented on issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
michellethomas commented on issue #12509:
URL: https://github.com/apache/superset/issues/12509#issuecomment-760452449
@hughhhh looks like this was changed in your https://github.com/apache/superset/pull/12067 Sql toolbar PR, thoughts on how we can get a higher sqllab limit back? Maybe if `SQL_MAX_ROW` is > 100,000 we can make `SQL_MAX_ROW` the last option? Or make the dropdown options configurable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #12509:
URL: https://github.com/apache/superset/issues/12509#issuecomment-760456423
We should replace that dropdown with a `CreatableSelect` (add set `mode="tags"` if using AntD select).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh edited a comment on issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
hughhhh edited a comment on issue #12509:
URL: https://github.com/apache/superset/issues/12509#issuecomment-760543514
Just put up #12529 with the fix tell me what you think.
@michellethomas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on issue #12509: Sqllab query max limit in query dropdown
Posted by GitBox <gi...@apache.org>.
hughhhh commented on issue #12509:
URL: https://github.com/apache/superset/issues/12509#issuecomment-760543514
Just put up #12529 with the fix tell me what you think
@michellethomas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org