You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/09/10 19:01:11 UTC
Review Request 25510: No deprecation warning after creating blueprint
with global configs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25510/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-7248
https://issues.apache.org/jira/browse/AMBARI-7248
Repository: ambari
Description
-------
**STR;**
1. Created blueprint from bp-PropertiesInGlobal-definition.json
"configurations" : [
{ "nagios-env" : { "nagios_contact" : "admin" } },
{ "global" : { "nagios_web_login" : "nagiosadmin" } }
]
**Result:** No warning message appeared while creating blueprint about deprecation of global config group.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestStatusResponse.java d6eabf4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java d14cdf3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 3307b59
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java b7430c8
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java f5d8227
Diff: https://reviews.apache.org/r/25510/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 25510: No deprecation warning after creating
blueprint with global configs
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25510/#review52901
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 10, 2014, 5:01 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25510/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2014, 5:01 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-7248
> https://issues.apache.org/jira/browse/AMBARI-7248
>
>
> Repository: ambari
>
>
> Description
> -------
>
> **STR;**
>
> 1. Created blueprint from bp-PropertiesInGlobal-definition.json
>
>
> "configurations" : [
> { "nagios-env" : { "nagios_contact" : "admin" } },
> { "global" : { "nagios_web_login" : "nagiosadmin" } }
> ]
>
>
> **Result:** No warning message appeared while creating blueprint about deprecation of global config group.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/RequestStatusResponse.java d6eabf4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java d14cdf3
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 3307b59
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java b7430c8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java f5d8227
>
> Diff: https://reviews.apache.org/r/25510/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>