[jira] [Resolved] (IMPALA-6016) Confusing logging in TableLoadingMgr.loadNextTable()

["bharath v (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bharath v resolved IMPALA-6016.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.11.0

https://github.com/apache/incubator-impala/commit/c189d0a39cfb106f369522c57926196cc772da5e

> Confusing logging in TableLoadingMgr.loadNextTable()
> ----------------------------------------------------
>
>                 Key: IMPALA-6016
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6016
>             Project: IMPALA
>          Issue Type: Improvement
>    Affects Versions: Impala 2.9.0, Impala 2.10.0
>            Reporter: bharath v
>            Assignee: bharath v
>             Fix For: Impala 2.11.0
>
>
> {noformat}
>  private void loadNextTable() throws InterruptedException {
>     // Always get the next table from the head of the deque.
>     final TTableName tblName = tableLoadingDeque_.takeFirst();
>     LOG.info("Loading next table from queue: " +
>         tblName.db_name + "." + tblName.table_name);
>     LOG.info(String.format("Remaining items in queue: %s. Loads in progress: %s",
>         tableLoadingDeque_.size(), loadingTables_.size()));
> {noformat}
> The last log is in an incorrect place, especially the "Loads in progress: %s" because the loadingTables_ for this specific load is not updated until loadAsync() is called and hence it doesn't reflect the actual situation. 
> Given this is a useful log, we should move it to a place where it actually polls correct values.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)