You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/04/10 12:35:42 UTC

Re: Review Request 29341: Fix docker recovery when launched in container and add more logging.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29341/#review79661
-----------------------------------------------------------



src/slave/containerizer/docker.hpp
<https://reviews.apache.org/r/29341/#comment129183>

    Suggestion: explain what role the executor argument plays in this.



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29341/#comment129184>

    According to thecomment starting on line 98, the former version of this code is correct, not the new version. Is the comment stale?



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29341/#comment129185>

    This comment now became redundant.



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29341/#comment129179>

    contianer -> container



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29341/#comment129180>

    Used twice => suggestion: factor it out and use a function name instead of a comment to explain what this does



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29341/#comment129182>

    How does what the comment says relate to the statement that follows?


- Bernd Mathiske


On Jan. 16, 2015, 5:38 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29341/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix docker recovery when launched in container and add more logging.
> Also delay removing the executor container so it can be introspected as well as the container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp b7bf54a 
>   src/slave/containerizer/docker.cpp 5f4b4ce 
> 
> Diff: https://reviews.apache.org/r/29341/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>