You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Bharat Viswanadham (JIRA)" <ji...@apache.org> on 2017/07/20 01:00:04 UTC
[jira] [Comment Edited] (HADOOP-14672) Shaded
Hadoop-client-minicluster include unshaded classes, like: javax, sax, dom,
etc.
[ https://issues.apache.org/jira/browse/HADOOP-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094034#comment-16094034 ]
Bharat Viswanadham edited comment on HADOOP-14672 at 7/20/17 12:59 AM:
-----------------------------------------------------------------------
Hi [~djp]
org/w3c/dom/, org/w3c/dom/, org/xml/sax/* and org/xml/sax/**/* are excluded from shading as these packages are part of the JDK.
[~busbey]
Uploaded the patch to fix the classes which are missed from shading. Could you please have a look in to this patch.
And also one more thing, as these classes package is little different than conventional, it is missed. So, in future if there are jars with package name changes, we need to update the pom.xml right?
Have not found any solution for this in general for relocating classes. Please let me know if i am missing something here.
Testing will identify the issues, but code update of pom.xml will be needed for all shaded jars. Is my understanding correct?
was (Author: bharatviswa):
Hi [~djp]
org/w3c/dom/, org/w3c/dom/, org/xml/sax/* and org/xml/sax/**/* are excluded from shading as these packages are part of the JDK.
[~busbey]
Uploaded the patch to fix the classes which are missed from shading. Could you please have a look in to this patch.
And also one more thing, as these classes package is little different than conventional, it is missed. So, in future if there are jars with package name changes, we need to update the pom.xml right?
Have not found any solution for this in general for relocating classes. Please let me know if i am missing something here.
Testing will identify the issues, but code update of pom.xml will be needed for all shaded jars. Is my understanding correct?
> Shaded Hadoop-client-minicluster include unshaded classes, like: javax, sax, dom, etc.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-14672
> URL: https://issues.apache.org/jira/browse/HADOOP-14672
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Bharat Viswanadham
> Priority: Blocker
> Attachments: HADOOP-14672.patch
>
>
> The shaded hadoop-client-minicluster shouldn't include any unshaded dependencies, but we can see: javax, dom, sax, etc. are all unshaded.
> CC [~busbey]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org