You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/27 08:09:29 UTC

[GitHub] [superset] geido opened a new pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

geido opened a new pull request #16851:
URL: https://github.com/apache/superset/pull/16851


   ### SUMMARY
   This PR fixes several issues related to the undo functionality in native filters. It stores the latest form data and adds it back to the form when the user removes a filter and then undoes the removal. 
   
   ### BEFORE
   See issue #16821
   
   ### AFTER
   
   https://user-images.githubusercontent.com/60598000/134869243-74396a24-218d-4fc2-beec-27b1ed8e3879.mp4
   
   ### TESTING INSTRUCTIONS
   1. Open a Dashboard with native filters enabled
   2. Add a filter
   3. Remove the filter
   4. Undo your action and make sure the latest data was preserved
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #16821
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina edited a comment on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927832001


   > @michael-s-molina as stated above, I confirm that the form is wiped out as soon as the form rerenders after the remove action. Any data you already have about the filter (such as the one in the `filterConfigMap` ) might be outdated as it does not contain the most recent state of the form. Thus, the only solution that seems to solve both scenarios is to store the current state of the form. I am happy to consider a different solution but it does not appear to be obvious at the moment. Let me know if anything different comes to your mind. Thank you!
   
   I was reviewing and found this:
   
   <img width="699" alt="Screen Shot 2021-09-27 at 9 34 12 AM" src="https://user-images.githubusercontent.com/70410625/134909339-540c806c-d633-4faa-9cde-9fbacbae6f2b.png">
   
   This is the code that is clearing the form. `preserve={false}` is forcing the values to be cleared. The default value of Ant Design is `true`. If we change it to `true`, the values are preserved after restoring. The only thing is that I don’t know why this was set to `false`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927776730


   @geido If I'm not mistaken when the user removes a filter, it only marks that filter as deleted but the form values are preserved. If that's the case, why do we need the `undoFormValues` state? Can't we just use the original form?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc merged pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
junlincc merged pull request #16851:
URL: https://github.com/apache/superset/pull/16851


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927703208


   /testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927780206


   > @geido If I'm not mistaken when the user removes a filter, it only marks that filter as deleted but the form values are preserved. If that's the case, why do we need the `undoFormValues` state? Can't we just use the original form?
   
   @michael-s-molina I checked that and it appears that when the filter is removed the form is also cleaned up. You won't have the most recent state of the form, hence I am storing it on removal and reapplying the values on undo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on a change in pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #16851:
URL: https://github.com/apache/superset/pull/16851#discussion_r716595309



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -550,15 +512,21 @@ const FiltersConfigForm = (
   }));
 
   const parentFilter = parentFilterOptions.find(
-    ({ value }) => value === filterToEdit?.cascadeParentIds[0],
+    ({ value }) =>
+      value === formFilter?.parentFilter?.value ||
+      value === filterToEdit?.cascadeParentIds?.[0],
   );
 
   const hasParentFilter = !!parentFilter;
 
   const hasPreFilter =
-    !!filterToEdit?.adhoc_filters || !!filterToEdit?.time_range;
+    !!formFilter?.adhoc_filters ||
+    !!formFilter?.time_range ||
+    !!filterToEdit?.adhoc_filters?.length ||
+    !!filterToEdit?.time_range;

Review comment:
       Thanks for your feedback! It appears that when the form doesn't have any filters it will just return undefined, reason why I am only checking for that here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-928058261


   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927830359


   @michael-s-molina as stated above, I confirm that the form is wiped out as soon as the form rerenders after the remove action. Any data you already have about the filter (such as the one in the `filterConfigMap` ) might be outdated as it does not contain the most recent state of the form. Thus, the only solution that seems to solve both scenarios is to store the current state of the form. I am happy to consider a different solution but it does not appear to be obvious at the moment. Let me know if anything different comes to your mind. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927784633


   > > @geido If I'm not mistaken when the user removes a filter, it only marks that filter as deleted but the form values are preserved. If that's the case, why do we need the `undoFormValues` state? Can't we just use the original form?
   > 
   > @michael-s-molina I checked that and it appears that when the filter is removed the form is also cleaned up. You won't have the most recent state of the form, hence I am storing it on removal and reapplying the values on undo.
   
   Do you know where the form is being cleared? This is the handler for the delete action and it's only marking it as removed. 
   
   ```
   export const createHandleTabEdit = (
     setRemovedFilters: (
       value:
         | ((
             prevState: Record<string, FilterRemoval>,
           ) => Record<string, FilterRemoval>)
         | Record<string, FilterRemoval>,
     ) => void,
     setSaveAlertVisible: Function,
     addFilter: Function,
   ) => (filterId: string, action: 'add' | 'remove') => {
     const completeFilterRemoval = (filterId: string) => {
       // the filter state will actually stick around in the form,
       // and the filterConfig/newFilterIds, but we use removedFilters
       // to mark it as removed.
       setRemovedFilters(removedFilters => ({
         ...removedFilters,
         [filterId]: { isPending: false },
       }));
     };
   
     if (action === 'remove') {
       // first set up the timer to completely remove it
       const timerId = window.setTimeout(
         () => completeFilterRemoval(filterId),
         REMOVAL_DELAY_SECS * 1000,
       );
       // mark the filter state as "removal in progress"
       setRemovedFilters(removedFilters => ({
         ...removedFilters,
         [filterId]: { isPending: true, timerId },
       }));
       setSaveAlertVisible(false);
     } else if (action === 'add') {
       addFilter();
     }
   };
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927632773


   @jinghua-qa @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927835569


   @geido We can investigate this in a follow-up since this is a P1. Approving for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927832001


   > @michael-s-molina as stated above, I confirm that the form is wiped out as soon as the form rerenders after the remove action. Any data you already have about the filter (such as the one in the `filterConfigMap` ) might be outdated as it does not contain the most recent state of the form. Thus, the only solution that seems to solve both scenarios is to store the current state of the form. I am happy to consider a different solution but it does not appear to be obvious at the moment. Let me know if anything different comes to your mind. Thank you!
   
   So I was reviewing and found this:
   
   <img width="699" alt="Screen Shot 2021-09-27 at 9 34 12 AM" src="https://user-images.githubusercontent.com/70410625/134909339-540c806c-d633-4faa-9cde-9fbacbae6f2b.png">
   
   This is the code that is clearing the form. `preserve={false}` is forcing the values to be cleared. The default value of Ant Design is `true`. If we change it to `true`, the values are preserved after restoring. The only thing is that I don’t know why this was set to `false`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] sadpandajoe commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-928139223


   🏷️ 2021.38


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927704595


   @geido Ephemeral environment spinning up at http://54.245.58.103:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on a change in pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #16851:
URL: https://github.com/apache/superset/pull/16851#discussion_r716551212



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -550,15 +512,21 @@ const FiltersConfigForm = (
   }));
 
   const parentFilter = parentFilterOptions.find(
-    ({ value }) => value === filterToEdit?.cascadeParentIds[0],
+    ({ value }) =>
+      value === formFilter?.parentFilter?.value ||
+      value === filterToEdit?.cascadeParentIds?.[0],
   );
 
   const hasParentFilter = !!parentFilter;
 
   const hasPreFilter =
-    !!filterToEdit?.adhoc_filters || !!filterToEdit?.time_range;
+    !!formFilter?.adhoc_filters ||
+    !!formFilter?.time_range ||
+    !!filterToEdit?.adhoc_filters?.length ||
+    !!filterToEdit?.time_range;

Review comment:
       should we also change it to `formFilter?.adhoc_filters?.length ||` like it is later for `filterToEdit`, just in case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] sadpandajoe commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-928139223


   🏷️ 2021.38


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina edited a comment on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927835569


   @geido We can investigate this in a follow-up since this is a P1. For now, let's merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927655012


   # [Codecov](https://codecov.io/gh/apache/superset/pull/16851?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16851](https://codecov.io/gh/apache/superset/pull/16851?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32a16a2) into [master](https://codecov.io/gh/apache/superset/commit/100760c4649d100981782785e96b975676d6244d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (100760c) will **increase** coverage by `0.00%`.
   > The diff coverage is `90.90%`.
   
   > :exclamation: Current head 32a16a2 differs from pull request most recent head 3e9c827. Consider uploading reports for the commit 3e9c827 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/16851/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/16851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #16851   +/-   ##
   =======================================
     Coverage   76.93%   76.94%           
   =======================================
     Files        1021     1021           
     Lines       54708    54724   +16     
     Branches     7459     7468    +9     
   =======================================
   + Hits        42092    42106   +14     
   - Misses      12372    12374    +2     
     Partials      244      244           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `71.14% <90.90%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/16851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16851/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.87% <90.90%> (+0.60%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16851?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16851?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [100760c...3e9c827](https://codecov.io/gh/apache/superset/pull/16851?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org