You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/10/27 01:39:50 UTC
[GitHub] [orc] wgtmac opened a new pull request, #1297: Upgrade Github workflow to build on Windows
wgtmac opened a new pull request, #1297:
URL: https://github.com/apache/orc/pull/1297
### What changes were proposed in this pull request?
Upgrade Github workflow to build on Windows to use higher version of Visual Studio. To be specific, the workflow uses Visual Studio 16 2019 instead of Visual Studio 14 2015.
### Why are the changes needed?
This is the prerequisite for the C++17 movement across the C++ code base.
### How was this patch tested?
Pass all the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1297: ORC-1302: Upgrade Github workflow to use `Visual Studio 16 2019` on Windows
Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #1297:
URL: https://github.com/apache/orc/pull/1297#issuecomment-1330130584
> Unfortunately, this seems to require #1298. After [750e615](https://github.com/apache/orc/commit/750e615091e399569e1f8a1c1491a5d2f343539c), Windows GitHub Action job of `branch-1.8` starts to fail at Google Test compilation.
>
> * https://github.com/apache/orc/actions/runs/3571364150/jobs/6003165821
>
> ```
> CMake Error at D:/a/orc/orc/build/googletest_ep-prefix/src/googletest_ep-stamp/googletest_ep-build-Debug.cmake:49 (message):
> Command failed: 1
> 'C:/Program Files/CMake/bin/cmake.exe' '--build' '.' '--config' 'Debug'
> ```
Does it mean that the it applies github workflow config from the main branch even for commits to branch-1.8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1297: ORC-1302: Upgrade Github workflow to use `Visual Studio 16 2019` on Windows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1297:
URL: https://github.com/apache/orc/pull/1297#issuecomment-1330126314
Unfortunately, this seems to require #1298. After 750e615091e399569e1f8a1c1491a5d2f343539c, Windows GitHub Action job of `branch-1.8` starts to fail at Google Test compilation.
- https://github.com/apache/orc/actions/runs/3571364150/jobs/6003165821
```
CMake Error at D:/a/orc/orc/build/googletest_ep-prefix/src/googletest_ep-stamp/googletest_ep-build-Debug.cmake:49 (message):
Command failed: 1
'C:/Program Files/CMake/bin/cmake.exe' '--build' '.' '--config' 'Debug'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1297: ORC-1302: Upgrade Github workflow to use `Visual Studio 16 2019` on Windows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1297:
URL: https://github.com/apache/orc/pull/1297#issuecomment-1330135826
This is reverted from branch-1.8 via https://github.com/apache/orc/commit/36c54888b6e0cab02ecdc6960ee6b189d921ee05
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1297: ORC-1302: Upgrade Github workflow to build on Windows
Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #1297:
URL: https://github.com/apache/orc/pull/1297#issuecomment-1294364094
> #1298 is merged. Could you rebase this PR?
Done.
I have tried windows-2022 but it ended up with error related to finding Visual Studio 2019.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1297: ORC-1302: Upgrade Github workflow to use `Visual Studio 16 2019` on Windows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1297: ORC-1302: Upgrade Github workflow to use `Visual Studio 16 2019` on Windows
URL: https://github.com/apache/orc/pull/1297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1297: ORC-1302: Upgrade Github workflow to use `Visual Studio 16 2019` on Windows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1297:
URL: https://github.com/apache/orc/pull/1297#issuecomment-1330133788
No~ I backported this to `branch-1.8` too at that time.
https://github.com/apache/orc/commit/7f99a7aa10695855a44cfb0b78f21d61a59c20c6
Let me revert this first from branch-1.8 to prepare Apache ORC 1.8.1 release. We can keep this for Apache ORC 1.9.0 and maybe 1.8.2 later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1297: ORC-1302: Upgrade Github workflow to use `Visual Studio 16 2019` on Windows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1297:
URL: https://github.com/apache/orc/pull/1297#issuecomment-1330167467
`branch-1.8` GitHub Action `Windows` job is recovered.
<img width="617" alt="Screenshot 2022-11-28 at 10 56 07 PM" src="https://user-images.githubusercontent.com/9700541/204460036-5cde7084-ac94-4c9f-94a2-eba375d7fa79.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1297: ORC-1302: Upgrade Github workflow to build on Windows
Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #1297:
URL: https://github.com/apache/orc/pull/1297#issuecomment-1294365828
cc @stiga-huang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org