You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Scott Gonyea (JIRA)" <ji...@apache.org> on 2010/09/14 23:16:34 UTC

[jira] Created: (LUCENE-2644) LowerCaseTokenizer Does Not Behave As One Might Expect (or Desire)--Given Its Name

LowerCaseTokenizer Does Not Behave As One Might Expect (or Desire)--Given Its Name
----------------------------------------------------------------------------------

                 Key: LUCENE-2644
                 URL: https://issues.apache.org/jira/browse/LUCENE-2644
             Project: Lucene - Java
          Issue Type: Bug
          Components: Analysis
    Affects Versions: 3.0.2
            Reporter: Scott Gonyea
             Fix For: 3.0.3, 3.1, Realtime Branch, 4.0


While I understand some of the reasons for its design, the original LowerCaseTokenizer should have been named LowerCaseLetterTokenizer.

I feel that LowerCaseTokenizer makes too many assumptions about what too tokenize, and I have therefore patched it.  The *default* behavior will remain as it always has--to avoid breaking any implementations for which it's being used.

I have changed LowerCaseTokenizer to extend CharTokenizer (rather than LetterTokenizer).  LetterTokenizer's functionality was merged into the default behavior of LowerCaseTokenizer.

Getter/Setter methods have been added to the LowerCaseTokenizer Class, allowing you to turn on / off tokenizing by white space, numbers, and special (Non-Alpha/Numeric) characters.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2644) LowerCaseTokenizer Does Not Behave As One Might Expect (or Desire)--Given Its Name

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2644:
--------------------------------

    Fix Version/s:     (was: Realtime Branch)
                       (was: 3.0.3)
                       (was: 3.1)
       Issue Type: Wish  (was: Bug)

> LowerCaseTokenizer Does Not Behave As One Might Expect (or Desire)--Given Its Name
> ----------------------------------------------------------------------------------
>
>                 Key: LUCENE-2644
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2644
>             Project: Lucene - Java
>          Issue Type: Wish
>          Components: Analysis
>    Affects Versions: 3.0.2
>            Reporter: Scott Gonyea
>             Fix For: 4.0
>
>         Attachments: LowerCaseTokenizer.patch
>
>
> While I understand some of the reasons for its design, the original LowerCaseTokenizer should have been named LowerCaseLetterTokenizer.
> I feel that LowerCaseTokenizer makes too many assumptions about what too tokenize, and I have therefore patched it.  The *default* behavior will remain as it always has--to avoid breaking any implementations for which it's being used.
> I have changed LowerCaseTokenizer to extend CharTokenizer (rather than LetterTokenizer).  LetterTokenizer's functionality was merged into the default behavior of LowerCaseTokenizer.
> Getter/Setter methods have been added to the LowerCaseTokenizer Class, allowing you to turn on / off tokenizing by white space, numbers, and special (Non-Alpha/Numeric) characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2644) LowerCaseTokenizer Does Not Behave As One Might Expect (or Desire)--Given Its Name

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922383#action_12922383 ] 

Robert Muir commented on LUCENE-2644:
-------------------------------------

I don't understand this issue, to me the LowerCaseTokenizer explains clearly what it does:

{noformat}
 * LowerCaseTokenizer performs the function of LetterTokenizer
 * and LowerCaseFilter together.  It divides text at non-letters and converts
 * them to lower case.
{noformat}

I think there is a lot of other options if you want to customize tokenization by numbers, punctuation etc, especially Solr's WordDelimiterFilter.


> LowerCaseTokenizer Does Not Behave As One Might Expect (or Desire)--Given Its Name
> ----------------------------------------------------------------------------------
>
>                 Key: LUCENE-2644
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2644
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 3.0.2
>            Reporter: Scott Gonyea
>             Fix For: 4.0
>
>         Attachments: LowerCaseTokenizer.patch
>
>
> While I understand some of the reasons for its design, the original LowerCaseTokenizer should have been named LowerCaseLetterTokenizer.
> I feel that LowerCaseTokenizer makes too many assumptions about what too tokenize, and I have therefore patched it.  The *default* behavior will remain as it always has--to avoid breaking any implementations for which it's being used.
> I have changed LowerCaseTokenizer to extend CharTokenizer (rather than LetterTokenizer).  LetterTokenizer's functionality was merged into the default behavior of LowerCaseTokenizer.
> Getter/Setter methods have been added to the LowerCaseTokenizer Class, allowing you to turn on / off tokenizing by white space, numbers, and special (Non-Alpha/Numeric) characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2644) LowerCaseTokenizer Does Not Behave As One Might Expect (or Desire)--Given Its Name

Posted by "Scott Gonyea (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gonyea updated LUCENE-2644:
---------------------------------

    Attachment: LowerCaseTokenizer.patch

This patch will retain original functionality, while permitting the user to modify the assumptions on which tokens are built.

> LowerCaseTokenizer Does Not Behave As One Might Expect (or Desire)--Given Its Name
> ----------------------------------------------------------------------------------
>
>                 Key: LUCENE-2644
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2644
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 3.0.2
>            Reporter: Scott Gonyea
>             Fix For: 3.0.3, 3.1, Realtime Branch, 4.0
>
>         Attachments: LowerCaseTokenizer.patch
>
>
> While I understand some of the reasons for its design, the original LowerCaseTokenizer should have been named LowerCaseLetterTokenizer.
> I feel that LowerCaseTokenizer makes too many assumptions about what too tokenize, and I have therefore patched it.  The *default* behavior will remain as it always has--to avoid breaking any implementations for which it's being used.
> I have changed LowerCaseTokenizer to extend CharTokenizer (rather than LetterTokenizer).  LetterTokenizer's functionality was merged into the default behavior of LowerCaseTokenizer.
> Getter/Setter methods have been added to the LowerCaseTokenizer Class, allowing you to turn on / off tokenizing by white space, numbers, and special (Non-Alpha/Numeric) characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org