You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2023/02/20 04:25:36 UTC
[spark] branch branch-3.4 updated: [SPARK-42427][SQL][TESTS][FOLLOW-UP] Remove duplicate overflow test for conv
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.4 by this push:
new ca268ef79eb [SPARK-42427][SQL][TESTS][FOLLOW-UP] Remove duplicate overflow test for conv
ca268ef79eb is described below
commit ca268ef79eb07800a97e5c5e30758a6617e7b41a
Author: Hyukjin Kwon <gu...@apache.org>
AuthorDate: Mon Feb 20 13:24:53 2023 +0900
[SPARK-42427][SQL][TESTS][FOLLOW-UP] Remove duplicate overflow test for conv
This PR proposes to remove duplicate test (see https://github.com/apache/spark/commit/cb463fb40e8f663b7e3019c8d8560a3490c241d0).
This test fails with ANSI mode on https://github.com/apache/spark/actions/runs/4213931226/jobs/7314033662, and it's a duplicate. Should better remove.
No, test-only.
Manually tested.
Closes #40088 from HyukjinKwon/SPARK-42427-followup.
Authored-by: Hyukjin Kwon <gu...@apache.org>
Signed-off-by: Hyukjin Kwon <gu...@apache.org>
(cherry picked from commit 4a816ee0925d9cbfe2bd73e512137379f3334a77)
Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala | 2 --
1 file changed, 2 deletions(-)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala
index 05eb877a60e..02fa7705e60 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala
@@ -222,8 +222,6 @@ class MathFunctionsSuite extends QueryTest with SharedSparkSession {
checkAnswer(df.selectExpr("conv(num, fromBase, toBase)"), Row("101001101"))
checkAnswer(df.selectExpr("""conv("100", 2, 10)"""), Row("4"))
checkAnswer(df.selectExpr("""conv("-10", 16, -10)"""), Row("-16"))
- checkAnswer(
- df.selectExpr("""conv("9223372036854775807", 36, -16)"""), Row("-1")) // for overflow
}
test("SPARK-33428 conv function should trim input string") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org