[GitHub] [kafka] mimaison commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

[GitBox <gi...@apache.org>]

mimaison commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r966049063


##########
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##########
@@ -1138,5 +1142,13 @@ else if (value instanceof Long)
     private String className(Object o) {
         return o != null ? o.getClass().getName() : "null";
     }
-}
 
+    private static void maybeAddClientId(Map<String, ? super String> clientProps, String groupId) {
+        String clientId = "connect-cluster";
+        if (groupId != null) {

Review Comment:
   Can `groupId` actually be null here? This should only run in distributed mode



##########
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##########
@@ -106,6 +108,7 @@ public Connect startConnect(Map<String, String> workerProps) {
         // Create the admin client to be shared by all backing stores.
         Map<String, Object> adminProps = new HashMap<>(config.originals());
         ConnectUtils.addMetricsContextProperties(adminProps, config, kafkaClusterId);
+        adminProps.putIfAbsent(CLIENT_ID_CONFIG, "connect-cluster-" + config.groupId());

Review Comment:
   With the default config, you get `connect-cluster-connect-cluster` for the client-id. I wonder if we need to add the `connect-cluster-` prefix at all?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org