You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/09/02 22:44:46 UTC

Re: Review Request 61297: Linked `mesos-protobufs` to `protobuf` imported library.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61297/#review184445
-----------------------------------------------------------


Ship it!




In the vein of other squashing in this review chain, I'm going to squash here a bunch of patches that cleanup the targets/linking-rules in Mesos:


    Review: https://reviews.apache.org/r/61298/
    Review: https://reviews.apache.org/r/61299/
    Review: https://reviews.apache.org/r/61310/
    Review: https://reviews.apache.org/r/61326/
    Review: https://reviews.apache.org/r/61341/
    Review: https://reviews.apache.org/r/61342/
    Review: https://reviews.apache.org/r/61349/
    Review: https://reviews.apache.org/r/61356/
    Review: https://reviews.apache.org/r/61359/
    Review: https://reviews.apache.org/r/61364/

- Joseph Wu


On Aug. 1, 2017, 5:54 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61297/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 5:54 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Linked `mesos-protobufs` to `protobuf` imported library.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 98ccaf41bf5e7d14164e1c8b6e49268ac865a52c 
> 
> 
> Diff: https://reviews.apache.org/r/61297/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>