You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/20 20:20:17 UTC

[GitHub] [incubator-superset] graceguo-supercat commented on issue #9180: [SIP-36] Migrate setupApp.js to setupApp.ts

graceguo-supercat commented on issue #9180: [SIP-36] Migrate setupApp.js to setupApp.ts
URL: https://github.com/apache/incubator-superset/pull/9180#issuecomment-589289462
 
 
   Since you are making migration to ts, could you add unit test for every new component? The overall test coverage seems keep going down.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org