[PATCH] Issue 2489 - Add support to JavaHL for storing SSL client certificate passphrases in OSX Keychain

[Jeremy Whitlock <jc...@gmail.com>]

Hi All,
    I have attached a patch to add support to JavaHL for storing SSL
client certificate passphrases in the OSX Keychain.  Support for
caching SSL client certificate passphrases in the OSX Keychain was
added to Subversion core at r32860.  The patch is also pasted at the
bottom of this mail and attached to Issue 2489:

http://subversion.tigris.org/issues/show_bug.cgi?id=2489

Please let me know if there is more I can do to get this approved.

-- 
Take care,

Jeremy Whitlock
http://www.thoughtspark.org



[[[
Add support to JavaHL for storing SSL client certificate passphrases in the
OSX Keychain.

* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::getContext): Add OSX Keychain SSL client certificate passphrase
   provider to the providers array.
]]]

Index: subversion/bindings/javahl/native/SVNClient.cpp
===================================================================
--- subversion/bindings/javahl/native/SVNClient.cpp (revision 32871)
+++ subversion/bindings/javahl/native/SVNClient.cpp (working copy)
@@ -1236,6 +1236,9 @@
 #ifdef SVN_HAVE_KEYCHAIN_SERVICES
     svn_auth_get_keychain_simple_provider(&provider, pool);
     APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
+
+    svn_auth_get_keychain_ssl_client_cert_pw_provider(&provider, pool);
+    APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
 #endif
 #ifdef SVN_HAVE_GNOME_KEYRING
     SVN_JNI_ERR(get_auth_provider(&provider, "gnome_keyring", "simple",

Re: [PATCH] Issue 2489 - Add support to JavaHL for storing SSL client certificate passphrases in OSX Keychain

[Senthil Kumaran S <se...@collab.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy Whitlock wrote:
>     I have attached a patch to add support to JavaHL for storing SSL
> client certificate passphrases in the OSX Keychain.  Support for
> caching SSL client certificate passphrases in the OSX Keychain was
> added to Subversion core at r32860.  The patch is also pasted at the
> bottom of this mail and attached to Issue 2489:

+1 to commit this patch.

- --
Senthil Kumaran S
http://www.stylesen.org/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIwNox9o1G+2zNQDgRAmAMAKCgTS3CNyzjLqcv0lxBczOUZNsQWgCgopgi
IWlvZu4qxJwyQmJ4QB9dZwE=
=/4jz
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org