You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/13 03:13:46 UTC
[GitHub] [spark] warrenzhu25 opened a new pull request #35498: [SPARK-34777][UI] StagePage input/output size records not show when r…
warrenzhu25 opened a new pull request #35498:
URL: https://github.com/apache/spark/pull/35498
### What changes were proposed in this pull request?
Determine whether show input/output size and records based on either has value, rather than only size.
Before:
After:
### Why are the changes needed?
Stage page UI not show input/output size and records even when records greater than zero. This is common when data source only have records metrics updated.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #35498: [SPARK-34777][UI] StagePage input/output size records not show when r…
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #35498:
URL: https://github.com/apache/spark/pull/35498#discussion_r825308118
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -404,8 +404,8 @@ $(document).ready(function () {
var responseBody = response;
var dataToShow = {};
- dataToShow.showInputData = responseBody.inputBytes > 0;
- dataToShow.showOutputData = responseBody.outputBytes > 0;
+ dataToShow.showInputData = responseBody.inputBytes > 0 || responseBody.inputRecords > 0 ;
+ dataToShow.showOutputData = responseBody.outputBytes > 0 || responseBody.outputRecords > 0;
Review comment:
How to reproduce this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35498: [SPARK-34777][UI] StagePage input/output size records not show when r…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35498:
URL: https://github.com/apache/spark/pull/35498#issuecomment-1038893280
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org