You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/15 14:25:03 UTC
[GitHub] [iotdb] CalvinKirs opened a new pull request, #7003: Upgrade maven-wrapper to 3.8.4 for performance improvements and ARM more native support
CalvinKirs opened a new pull request, #7003:
URL: https://github.com/apache/iotdb/pull/7003
maven-wrapper is donated to ASF with a version upgraded, I'm upgrading to the new version 3.1.0 that was released under ASF umbrella.
Also upgrade maven version to 3.8.4 that was said to have performance improvements and better support in ARM architecture.
Modify mvnw.sh to mvnw, which is more of a convention, and most projects will use mvnw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CalvinKirs commented on a diff in pull request #7003: Upgrade maven-wrapper to 3.8.4 for performance improvements and ARM more native support
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #7003:
URL: https://github.com/apache/iotdb/pull/7003#discussion_r946355423
##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -1,2 +1,19 @@
-distributionUrl=https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip
-#wrapperUrl=https://repo1.maven.org/maven2/io/takari/maven-wrapper/0.2.1/maven-wrapper-0.2.1.jar
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/apache-maven-3.8.4-bin.zip
Review Comment:
thx, updated~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #7003: Upgrade maven-wrapper to 3.8.4 for performance improvements and ARM more native support
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7003:
URL: https://github.com/apache/iotdb/pull/7003#discussion_r946320703
##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -1,2 +1,19 @@
-distributionUrl=https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip
-#wrapperUrl=https://repo1.maven.org/maven2/io/takari/maven-wrapper/0.2.1/maven-wrapper-0.2.1.jar
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/apache-maven-3.8.4-bin.zip
Review Comment:
Thanks for your contribution! Just one question.
Why not upgrade to the latest version 3.8.6?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #7003: Upgrade maven-wrapper to 3.8.6 for performance improvements and ARM more native support
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7003:
URL: https://github.com/apache/iotdb/pull/7003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #7003: Upgrade maven-wrapper to 3.8.4 for performance improvements and ARM more native support
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7003:
URL: https://github.com/apache/iotdb/pull/7003#discussion_r946365784
##########
.github/workflows/client-go.yml:
##########
@@ -53,7 +53,7 @@ jobs:
key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
restore-keys: ${{ runner.os }}-m2-
- name: Compile IoTDB Server
- run: mvn -B package -Dmaven.test.skip=true -am -pl server
Review Comment:
Hi, I don't think using maven-wrapper in all CI workflows is a good idea. It seems take more time than preinstalled maven.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CalvinKirs commented on a diff in pull request #7003: Upgrade maven-wrapper to 3.8.6 for performance improvements and ARM more native support
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #7003:
URL: https://github.com/apache/iotdb/pull/7003#discussion_r947389451
##########
.github/workflows/client-go.yml:
##########
@@ -53,7 +53,7 @@ jobs:
key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
restore-keys: ${{ runner.os }}-m2-
- name: Compile IoTDB Server
- run: mvn -B package -Dmaven.test.skip=true -am -pl server
Review Comment:
revert.It looks like it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org