You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by WireBaron <gi...@git.apache.org> on 2017/08/15 18:47:52 UTC
[GitHub] geode pull request #713: Feature/geode 3412
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/713
Feature/geode 3412
This is adding some files which should have been in the last commit for this feature.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WireBaron/geode feature/GEODE-3412
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/713.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #713
----
commit daa140875c4f65838dde4ae0f627a9551bea7516
Author: Brian Rowe <br...@pivotal.io>
Date: 2017-08-10T18:16:25Z
GEODE-3412: Add simple authentication flow to protobuf protocol.
This change adds a simple username/password validation to the protobuf protocol.
It also adds a new configuration parameter to specify the type of authentication required.
Signed-off-by: Galen O'Sullivan <go...@pivotal.io>
commit 6753916687b9d916e18c3be5959f4c6aff490800
Author: Brian Rowe <br...@pivotal.io>
Date: 2017-08-14T17:29:21Z
GEODE-3412: implementing review feedback
commit b11c02a59cb2d71d4ac7d0b821ca668c825e2f6c
Author: Brian Rowe <br...@pivotal.io>
Date: 2017-08-15T17:09:39Z
GEODE-3412: moving authenticator interface to geode.security package
commit 704b6953e01a152e6859d4b254f4d8d39bd40011
Author: Brian Rowe <br...@pivotal.io>
Date: 2017-08-15T18:21:51Z
GEODE-3412: adding files missing from last commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #713: Feature/geode 3412
Posted by WireBaron <gi...@git.apache.org>.
Github user WireBaron closed the pull request at:
https://github.com/apache/geode/pull/713
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---