You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "Thad Guidry (JIRA)" <ji...@apache.org> on 2016/02/03 04:53:39 UTC
[jira] [Comment Edited] (NIFI-1395) CharacterSet Conversion tests
fail build on Windows 10
[ https://issues.apache.org/jira/browse/NIFI-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129739#comment-15129739 ]
Thad Guidry edited comment on NIFI-1395 at 2/3/16 3:53 AM:
-----------------------------------------------------------
1. Interestingly, this might be somewhat dependent on my Git Config itself with core.autocrlf=true
2. So, I just changed to =false and have refreshed and reset my repository as described here: https://help.github.com/articles/dealing-with-line-endings/#refreshing-a-repository-after-changing-line-endings
3. then performed a mvn clean install.
Now the nifi.processors.standard tests have passed, BUT the kite processor tests still fail.
Hmm, since some of the tests themselves depend on comparing files, and the FlowFile content created when the tests are run have different line endings on Windows than the original Linux / Mac OS X input FlowFiles that they are compared against then....
A. Perhaps the tests themselves can be improved for multi-platform build and tests ?
B. Maybe there is a global config setting for Surefire asserts to ignore line endings ? But that might be the wrong course of action and harmful in certain tests where the expectation is that the line endings in the FlowFiles should not be changing.
was (Author: thadguidry):
1. Interestingly, this might be somewhat dependent on my Git Config itself with core.autocrlf=true
2. So, I just changed to =false and have refreshed and reset my repository as described here: https://help.github.com/articles/dealing-with-line-endings/#refreshing-a-repository-after-changing-line-endings
3. then performed a mvn clean install.
Now the nifi.processors.standard tests have passed, BUT the kite processor tests still fail.
Hmm, since some of the tests themselves depend on comparing files, and the FlowFile content created when the tests are run have different line endings on Windows than the original Linux / Mac OS X input FlowFiles that they are compared against then....
A. Perhaps the tests themselves can be improved for multi-platform build and tests ?
B. Maybe there is a global config setting for Surefire asserts to ignore line endings ? But that might the wrong course of action and harmful in certain tests where the expectation is that the line endings in the FlowFiles should not be changing.
> CharacterSet Conversion tests fail build on Windows 10
> ------------------------------------------------------
>
> Key: NIFI-1395
> URL: https://issues.apache.org/jira/browse/NIFI-1395
> Project: Apache NiFi
> Issue Type: Bug
> Environment: Windows 10 64bit
> Java 1.8.0_66
> Reporter: Thad Guidry
>
> The test Original.txt files have UNIX Linefeeds (ascii char 10), but when the tests are run on Windows, the FlowFile created will have DOS format Carriage Returns (ascii char 13).
> {quote}
> Running org.apache.nifi.processors.standard.TestConvertCharacterSet
> Tests run: 4, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.163 sec <<< FAILURE! - in org.apache.nifi.processors.standard.TestConvertCharacterSet
> testExpressionLanguageOutput(org.apache.nifi.processors.standard.TestConvertCharacterSet) Time elapsed: 0.025 sec <<< FAILURE!
> java.lang.AssertionError: FlowFile content differs from input at byte 287 with input having value 10 and FlowFile having value 13
> at org.apache.nifi.processors.standard.TestConvertCharacterSet.testExpressionLanguageOutput(TestConvertCharacterSet.java:77)
> testExpressionLanguageInput(org.apache.nifi.processors.standard.TestConvertCharacterSet) Time elapsed: 0.015 sec <<< FAILURE!
> java.lang.AssertionError: FlowFile content differs from input at byte 287 with input having value 10 and FlowFile having value 13
> at org.apache.nifi.processors.standard.TestConvertCharacterSet.testExpressionLanguageInput(TestConvertCharacterSet.java:61)
> testSimple(org.apache.nifi.processors.standard.TestConvertCharacterSet) Time elapsed: 0.04 sec <<< FAILURE!
> java.lang.AssertionError: FlowFile content differs from input at byte 287 with input having value 10 and FlowFile having value 13
> at org.apache.nifi.processors.standard.TestConvertCharacterSet.testSimple(TestConvertCharacterSet.java:45)
> {quote}
> Additionally, org.apache.nifi.processors.standard.TestUnpackContent also has some similar failures...
> {quote}
> TestUnpackContent.testFlowFileStreamV2:150 FlowFile content differs from input at byte 20 with input having value 13 and FlowFile having value 10
> TestUnpackContent.testFlowFileStreamV3:127 FlowFile content differs from input at byte 20 with input having value 13 and FlowFile having value 10
> TestUnpackContent.testTar:72 FlowFile content differs from input at byte 20 with input having value 13 and FlowFile having value 10
> TestUnpackContent.testZip:104 FlowFile content differs from input at byte 20 with input having value 13 and FlowFile having value 10
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)