[GitHub] [jmeter] ubikloadpack commented on a change in pull request #640: Fix to 65041

[GitBox <gi...@apache.org>]

ubikloadpack commented on a change in pull request #640:
URL: https://github.com/apache/jmeter/pull/640#discussion_r674533696



##########
File path: src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPHCAbstractImpl.java
##########
@@ -143,6 +141,9 @@
 
     protected HTTPHCAbstractImpl(HTTPSamplerBase testElement) {
         super(testElement);
+        if(!StringUtils.isEmpty(JMeterUtils.getProperty("hc.parameters.file"))) { //$NON-NLS-1$

Review comment:
       Why not load this from a static block instead of loading it for each construction of an object ? 

##########
File path: src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/sampler/TestHTTPHC4Impl.java
##########
@@ -33,11 +39,14 @@
 import org.apache.jmeter.threads.JMeterContext;
 import org.apache.jmeter.threads.JMeterContextService;
 import org.apache.jmeter.threads.JMeterVariables;
+import org.apache.jmeter.util.JMeterUtils;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.parallel.Execution;
 import org.junit.jupiter.api.parallel.ExecutionMode;
 
+import static org.junit.Assert.*;

Review comment:
       Same note on * import

##########
File path: src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPHCAbstractImpl.java
##########
@@ -19,11 +19,7 @@
 
 import java.net.InetAddress;
 import java.net.UnknownHostException;
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
-import java.util.StringTokenizer;
+import java.util.*;

Review comment:
       Can you fix this star import ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org