You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Michi Mutsuzaki (JIRA)" <ji...@apache.org> on 2014/10/15 10:05:34 UTC

[jira] [Commented] (ZOOKEEPER-2000) Fix ReconfigTest.testPortChange

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172120#comment-14172120 ] 

Michi Mutsuzaki commented on ZOOKEEPER-2000:
--------------------------------------------

Hi Alex, is this patch good to go? I'm seeing this test fail once in a while in the precommit build:

https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-Build/2389/

> Fix ReconfigTest.testPortChange
> -------------------------------
>
>                 Key: ZOOKEEPER-2000
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2000
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.5.0
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Minor
>             Fix For: 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-2000.patch, ZOOKEEPER-2000.patch
>
>
>           testPortChange changes all ports and role of the server and thus causes existing clients to disconnect, while this wouldn't happen if only the client port changes. Need to fix it to only change client port and not all the other parameters and make sure that the clients don't disconnect, while new clients shouldn't be able to connect to the old port.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)