You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/08/20 08:59:16 UTC
[jira] Created: (CASSANDRA-1413) EstimatedHistogram.max is buggy
EstimatedHistogram.max is buggy
-------------------------------
Key: CASSANDRA-1413
URL: https://issues.apache.org/jira/browse/CASSANDRA-1413
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.7 beta 2
Attachments: 1413.txt
EH.max returns the largest bucket floor, which will will be LESS than the largest value added to the histogram, which is not the usual behavior expected of a method called max.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1413) EstimatedHistogram.max is buggy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900829#action_12900829 ]
Jonathan Ellis commented on CASSANDRA-1413:
-------------------------------------------
Dunno, that's why I wanted you to review. You sized those EHes. :)
Isn't the "right" solution just to make them large enough?
Open to other ideas.
> EstimatedHistogram.max is buggy
> -------------------------------
>
> Key: CASSANDRA-1413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 1413.txt
>
>
> EH.max returns the largest bucket floor, which will will be LESS than the largest value added to the histogram, which is not the usual behavior expected of a method called max.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1413) EstimatedHistogram.max is buggy
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900822#action_12900822 ]
Brandon Williams commented on CASSANDRA-1413:
---------------------------------------------
Isn't the ISE being thrown here going to get raised in CFS when cfstats is called?
> EstimatedHistogram.max is buggy
> -------------------------------
>
> Key: CASSANDRA-1413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 1413.txt
>
>
> EH.max returns the largest bucket floor, which will will be LESS than the largest value added to the histogram, which is not the usual behavior expected of a method called max.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1413) EstimatedHistogram.max is buggy
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-1413:
----------------------------------------
Attachment: 0002_adjust_EH_sizes.txt
I think we need to adjust the sizes a bit. Bump the column count EH to 114, giving us a max of about 2.4B columns (113 allows for 1996099046), and bump the row size EH to 150, allowing for almost a 1.7T row. It's theoretically possible to make a row larger than that, but I think having cfstats throw an exception will be the least of the user's problems at that point.
> EstimatedHistogram.max is buggy
> -------------------------------
>
> Key: CASSANDRA-1413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 0002_adjust_EH_sizes.txt, 1413.txt
>
>
> EH.max returns the largest bucket floor, which will will be LESS than the largest value added to the histogram, which is not the usual behavior expected of a method called max.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1413) EstimatedHistogram.max is buggy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1413:
--------------------------------------
Attachment: 1413.txt
> EstimatedHistogram.max is buggy
> -------------------------------
>
> Key: CASSANDRA-1413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 1413.txt
>
>
> EH.max returns the largest bucket floor, which will will be LESS than the largest value added to the histogram, which is not the usual behavior expected of a method called max.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.