[GitHub] [incubator-iceberg] mehtaashish23 commented on issue #894: [WIP] Spark: Implement an action to remove orphan files

[GitBox <gi...@apache.org>]

mehtaashish23 commented on issue #894: [WIP] Spark: Implement an action to remove orphan files
URL: https://github.com/apache/incubator-iceberg/pull/894#issuecomment-611334012
 
 
   Thanks @aokolnychyi for the PR. Based on what I see on PR, you are trying to clean up files that are not referenced by `metadata` table and `all_data_files` table. I am actually going to verify it, as I get to use this work in our project, but do the files which fail to get deleted during cleanup after commit [here], is also cleaned up with this work? My point is whether the dataFile which is deleted as part of an expired snapshot belongs to `all_data_files` table or not.
   
   [here]: https://github.com/apache/incubator-iceberg/blob/master/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java#L145

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org