[GitHub] [spark] maryannxue commented on a change in pull request #26400: [SPARK-29759][SQL] LocalShuffleReaderExec.outputPartitioning should use the corrected attributes

[GitBox <gi...@apache.org>]

maryannxue commented on a change in pull request #26400: [SPARK-29759][SQL] LocalShuffleReaderExec.outputPartitioning should use the corrected attributes
URL: https://github.com/apache/spark/pull/26400#discussion_r342731489
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala
 ##########
 @@ -219,11 +217,15 @@ case class ReusedQueryStageExec(
     }
   }
 
-  override def outputPartitioning: Partitioning = plan.outputPartitioning match {
+  private[sql] def updatePartitioning(p: Partitioning): Partitioning = p match {
 
 Review comment:
   nit: Is there a better place to put this method in, as well as `updateAttr`, like in `Attribute` or sth., so that they can be shared between `ReusedExchangeExec` and `ReusedQueryStageExec`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org