You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/04/03 07:03:06 UTC

[GitHub] spark pull request #17518: [SPARK-20198] [SQL] Remove the inconsistency in t...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17518#discussion_r109350128
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala ---
    @@ -413,11 +425,15 @@ class CatalogSuite
     
             // Find a qualified table
             assert(spark.catalog.tableExists(db, "tbl_y"))
    +        assert(spark.catalog.tableExists(s"$db.tbl_y"))
     
             // Find an unqualified table using the current database
             assert(!spark.catalog.tableExists("tbl_y"))
             spark.catalog.setCurrentDatabase(db)
             assert(spark.catalog.tableExists("tbl_y"))
    +
    +        // Unable to find the table, although the temp view with the given name exists
    +        assert(!spark.catalog.tableExists(db, "tbl_x"))
    --- End diff --
    
    This new test case is not related to this PR. Just to improve the existing test case coverage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org