You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Jarek Potiuk (Jira)" <ji...@apache.org> on 2020/02/19 20:23:00 UTC

[jira] [Resolved] (AIRFLOW-6839) Even more mypy speedup

     [ https://issues.apache.org/jira/browse/AIRFLOW-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Potiuk resolved AIRFLOW-6839.
-----------------------------------
    Fix Version/s: 1.10.10
       Resolution: Fixed

> Even more mypy speedup
> ----------------------
>
>                 Key: AIRFLOW-6839
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6839
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: pre-commit
>    Affects Versions: 2.0.0, 1.10.9
>            Reporter: Jarek Potiuk
>            Priority: Major
>             Fix For: 1.10.10
>
>
> require_serial:true is better choice than pass_filename: false as it can speed-up mypy for single file changes.
> Significant gains can be achieved for single file changes and no cache for all other files. This is majority of cases for our users who have pre-commits installed as hooks because most people change only few files and never run check with --all-files 
> When just one file is changed and no cache is built, the difference is drastic:
> require_serial: true (4s) 
>  
> {code:java}
> Run mypy.................................................................PassedRun mypy.................................................................Passed
> real 0m4,080s user 0m0,283s sys 0m0,095s
> {code}
> pass_filenames: false: (13s)
> {code:java}
> time pre-commit run mypy time pre-commit run mypyRun mypy.................................................................Passed
> real 0m13,756suser 0m0,281ssys 0m0,099s{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)