[jira] Commented: (OFBIZ-19) webtools jsp removal (started but now stopped)

["David E. Jones (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/OFBIZ-19?page=comments#action_12415829 ] 

David E. Jones commented on OFBIZ-19:
-------------------------------------

Some comments on this patch:

- this patch had parts of an already committed patch in it, so the patch failed for the CommonScreens.xml file
- changed the Main screen to "main" to be consistent with other stuff
- removed the view-map for main with regions tag which wasn't removed in the patch
- the new main.ftl page has no license header

The biggest issue is that the main.ftl page still has tons of JSP specific markup and such in it, and doesn't really work or look right as an FTL file...

There are also other issues like no login link in the header. I'm also not sure about this style of header for WebTools because there are many screens for each of these areas, and the link targets selected don't lead to the other tools and such (and I noticed they aren't consistent, the Entity one goes to the entity data maintenance page, but the Service one goes to the service reference...). So, I'm reverting out the menu back to the appheader.ftl file and slimming it down to the original links.


> webtools jsp removal (started but now stopped)
> ----------------------------------------------
>
>          Key: OFBIZ-19
>          URL: http://issues.apache.org/jira/browse/OFBIZ-19
>      Project: The Open For Business Project
>         Type: Improvement

>   Components: framework
>     Reporter: Hans Bakker
>     Assignee: David E. Jones
>  Attachments: webTooldAppmenu.patch
>
> attached a first step to remove the jsp files. A appl menu is inserted using menus.xml, but also in the header.ftl  to keep it operational in the mean time.
> Because i have other patches to the framework which get in the way and which do not seem to get  in after several requests, i stop now working on the framework until they do. It is at the moment too cumbersome to update the framework.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira