You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "anoopj (via GitHub)" <gi...@apache.org> on 2025/04/17 16:06:19 UTC
[PR] Use the same property map for TableInfo [spark]
anoopj opened a new pull request, #50625:
URL: https://github.com/apache/spark/pull/50625
### What changes were proposed in this pull request?
In `DataSourceV2`, we introduced a new `TableInfo` structure as part of https://github.com/apache/spark/pull/50137. This PR makes the changes such that we use the same property map from Spark instead of creating a new one.
### Why are the changes needed?
Retain the existing behavior, since the original PR was a refactoring change.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51372][SQL][FOLLOW-UP] Retain the property map for DataSourceV2 TableInfo [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #50625: [SPARK-51372][SQL][FOLLOW-UP] Retain the property map for DataSourceV2 TableInfo
URL: https://github.com/apache/spark/pull/50625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51372][SQL][FOLLOW-UP] Retain the property map for DataSourceV2 TableInfo [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50625:
URL: https://github.com/apache/spark/pull/50625#issuecomment-2814248593
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51372][SQL][FOLLOW-UP] Retain the property map for DataSourceV2 TableInfo [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #50625:
URL: https://github.com/apache/spark/pull/50625#issuecomment-2814252809
I think it's ok without a test, as it's a follow-up to revert an unintentional change from the previous PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51372][SQL][FOLLOW-UP] Retain the property map for DataSourceV2 TableInfo [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50625:
URL: https://github.com/apache/spark/pull/50625#issuecomment-2814185697
Can we add a test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51372][SQL][FOLLOW-UP] Retain the property map for DataSourceV2 TableInfo [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50625:
URL: https://github.com/apache/spark/pull/50625#issuecomment-2814257749
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org