[GitHub] [incubator-mxnet] RafLit commented on a diff in pull request #21056: [BUGFIX] Fix mkldnn segfault in reshape operator

[GitBox <gi...@apache.org>]

RafLit commented on code in PR #21056:
URL: https://github.com/apache/incubator-mxnet/pull/21056#discussion_r891760571


##########
src/operator/nn/mkldnn/mkldnn_reshape.cc:
##########
@@ -127,6 +127,8 @@ void MKLDNNReshapeForward(const nnvm::NodeAttrs& attrs,
   // For mkldnn non-supported input, it shouldn't hold mkldnn memory, so let's simply fallback to
   // naive implement.
   const int input_ndims = input.shape().ndim();
+  CHECK(input.shape().Size() == output.shape().Size())

Review Comment:
   The condition should be valid but it won't be used for generic MXNet path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org