You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2006/06/20 17:36:29 UTC
[jira] Created: (HARMONY-627) [classlib] [beans] enabling more
tests for java.beans
[classlib] [beans] enabling more tests for java.beans
-----------------------------------------------------
Key: HARMONY-627
URL: http://issues.apache.org/jira/browse/HARMONY-627
Project: Harmony
Type: Bug
Components: Classlib
Environment: win32 p4
Reporter: Alexei Zakharov
The following tests currently fail:
org.apache.harmony.beans.ClassPersistenceDelegateTest
org.apache.harmony.beans.StringPersistenceDelegateTest
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-627) [classlib] [beans] enabling more
tests for java.beans
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-627?page=all ]
Mark Hindess reassigned HARMONY-627:
------------------------------------
Assign To: Mark Hindess
> [classlib] [beans] enabling more tests for java.beans
> -----------------------------------------------------
>
> Key: HARMONY-627
> URL: http://issues.apache.org/jira/browse/HARMONY-627
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: win32 p4
> Reporter: Alexei Zakharov
> Assignee: Mark Hindess
> Attachments: PDTests.patch
>
> The following tests currently fail:
> org.apache.harmony.beans.ClassPersistenceDelegateTest
> org.apache.harmony.beans.StringPersistenceDelegateTest
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-627) [classlib] [beans] enabling more
tests for java.beans
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-627?page=all ]
Mark Hindess resolved HARMONY-627:
----------------------------------
Resolution: Fixed
Tim: Sorry, I'd already figured the patch out when I saw this comment so I'll check it in just this once.
Alexei: This was an odd patch, even when I got the patch to apply (by rolling to the revision you were working from, running dos2unix and stripping carriage returns from the patch - there were still lots of spurious whitespace differences in the build.xml file.
Checked in as r415773. Please check it is applied as expected.
> [classlib] [beans] enabling more tests for java.beans
> -----------------------------------------------------
>
> Key: HARMONY-627
> URL: http://issues.apache.org/jira/browse/HARMONY-627
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: win32 p4
> Reporter: Alexei Zakharov
> Assignee: Mark Hindess
> Attachments: PDTests.patch
>
> The following tests currently fail:
> org.apache.harmony.beans.ClassPersistenceDelegateTest
> org.apache.harmony.beans.StringPersistenceDelegateTest
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-627) [classlib] [beans] enabling more
tests for java.beans
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-627?page=comments#action_12416981 ]
Alexei Zakharov commented on HARMONY-627:
-----------------------------------------
Hi,
Oops, it seems my IDE has perfomed tabs to spaces conversion, sorry for this. The real change in build.xml was the removal of three lines
<batchtest todir="${hy.tests.reports}" haltonfailure="no"
unless="test.case">
<fileset dir="${hy.beans.src.test.internal}">
<include name="**/*Test.java"/>
- <!-- Excluded pending investigation -->
- <exclude name="org/apache/harmony/beans/ClassPersistenceDelegateTest.java" />
- <exclude name="org/apache/harmony/beans/StringPersistenceDelegateTest.java" />
</fileset>
</batchtest>
Mark: I will check your updates tomorrow. Thanks.
> [classlib] [beans] enabling more tests for java.beans
> -----------------------------------------------------
>
> Key: HARMONY-627
> URL: http://issues.apache.org/jira/browse/HARMONY-627
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: win32 p4
> Reporter: Alexei Zakharov
> Assignee: Mark Hindess
> Attachments: PDTests.patch
>
> The following tests currently fail:
> org.apache.harmony.beans.ClassPersistenceDelegateTest
> org.apache.harmony.beans.StringPersistenceDelegateTest
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-627) [classlib] [beans] enabling more tests
for java.beans
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-627?page=all ]
Mark Hindess closed HARMONY-627:
--------------------------------
Verified by Alexei.
> [classlib] [beans] enabling more tests for java.beans
> -----------------------------------------------------
>
> Key: HARMONY-627
> URL: http://issues.apache.org/jira/browse/HARMONY-627
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: win32 p4
> Reporter: Alexei Zakharov
> Assignee: Mark Hindess
> Attachments: PDTests.patch
>
> The following tests currently fail:
> org.apache.harmony.beans.ClassPersistenceDelegateTest
> org.apache.harmony.beans.StringPersistenceDelegateTest
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-627) [classlib] [beans] enabling more
tests for java.beans
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-627?page=comments#action_12416928 ]
Tim Ellison commented on HARMONY-627:
-------------------------------------
Alexei, please could you send an updated patch to the moved build.xml? It's hard to see what you changed since every line is replaced.
Thanks.
> [classlib] [beans] enabling more tests for java.beans
> -----------------------------------------------------
>
> Key: HARMONY-627
> URL: http://issues.apache.org/jira/browse/HARMONY-627
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: win32 p4
> Reporter: Alexei Zakharov
> Attachments: PDTests.patch
>
> The following tests currently fail:
> org.apache.harmony.beans.ClassPersistenceDelegateTest
> org.apache.harmony.beans.StringPersistenceDelegateTest
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-627) [classlib] [beans] enabling more
tests for java.beans
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-627?page=comments#action_12417096 ]
Alexei Zakharov commented on HARMONY-627:
-----------------------------------------
Everything works properly, thanks.
> [classlib] [beans] enabling more tests for java.beans
> -----------------------------------------------------
>
> Key: HARMONY-627
> URL: http://issues.apache.org/jira/browse/HARMONY-627
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: win32 p4
> Reporter: Alexei Zakharov
> Assignee: Mark Hindess
> Attachments: PDTests.patch
>
> The following tests currently fail:
> org.apache.harmony.beans.ClassPersistenceDelegateTest
> org.apache.harmony.beans.StringPersistenceDelegateTest
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-627) [classlib] [beans] enabling more
tests for java.beans
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-627?page=all ]
Alexei Zakharov updated HARMONY-627:
------------------------------------
Attachment: PDTests.patch
Attached patch fixes mutatesTo() methods of ClassPersistenceDelegate and StringPersistenceDelegate. Now Class can mutate only to the Class with the same name (checked via getName()). String can mutate to the same string (checked via equals). The patch also updates ClassPersistenceDelegateTest to bring it in correspondance with currently implemented ClassPersistenceDelegate architecture.
Now we can enable ClassPersistenceDelegateTest and StringPersistenceDelegateTest. Thus we have all internal tests passed for java.beans!
> [classlib] [beans] enabling more tests for java.beans
> -----------------------------------------------------
>
> Key: HARMONY-627
> URL: http://issues.apache.org/jira/browse/HARMONY-627
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: win32 p4
> Reporter: Alexei Zakharov
> Attachments: PDTests.patch
>
> The following tests currently fail:
> org.apache.harmony.beans.ClassPersistenceDelegateTest
> org.apache.harmony.beans.StringPersistenceDelegateTest
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira