You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2022/07/18 19:01:56 UTC

[GitHub] [storm] snikhil5 opened a new pull request, #3488: STORM-3873: Remove junit4 dependency

snikhil5 opened a new pull request, #3488:
URL: https://github.com/apache/storm/pull/3488

   ## What is the purpose of the change
   
   Remove junit4 from storm-hdfs and storm-hdfs blobstore to completely remove junit4 from Storm.
   
   
   ## How was the change tested
   
   built locally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] agresch commented on a diff in pull request #3488: STORM-3873: Remove junit4 dependency

Posted by GitBox <gi...@apache.org>.
agresch commented on code in PR #3488:
URL: https://github.com/apache/storm/pull/3488#discussion_r924587620


##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/testing/MiniDFSClusterExtensionClassLevel.java:
##########
@@ -52,6 +55,8 @@ public MiniDFSCluster getDfscluster() {
     public void beforeAll(ExtensionContext arg0) throws Exception {
         System.setProperty(TEST_BUILD_DATA, "target/test/data");
         hadoopConf = hadoopConfSupplier.get();
+        String tempDir = getTestDir("dfs").getAbsolutePath() + File.separator;

Review Comment:
   Thanks for the explanation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] bipinprasad merged pull request #3488: STORM-3873: Remove junit4 dependency

Posted by GitBox <gi...@apache.org>.
bipinprasad merged PR #3488:
URL: https://github.com/apache/storm/pull/3488


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] agresch commented on a diff in pull request #3488: STORM-3873: Remove junit4 dependency

Posted by GitBox <gi...@apache.org>.
agresch commented on code in PR #3488:
URL: https://github.com/apache/storm/pull/3488#discussion_r924548205


##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/testing/MiniDFSClusterExtensionClassLevel.java:
##########
@@ -52,6 +55,8 @@ public MiniDFSCluster getDfscluster() {
     public void beforeAll(ExtensionContext arg0) throws Exception {
         System.setProperty(TEST_BUILD_DATA, "target/test/data");
         hadoopConf = hadoopConfSupplier.get();
+        String tempDir = getTestDir("dfs").getAbsolutePath() + File.separator;

Review Comment:
   is this somehow related to junit changes or is this some cleanup to use a test dir?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] snikhil5 commented on a diff in pull request #3488: STORM-3873: Remove junit4 dependency

Posted by GitBox <gi...@apache.org>.
snikhil5 commented on code in PR #3488:
URL: https://github.com/apache/storm/pull/3488#discussion_r924583718


##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/testing/MiniDFSClusterExtensionClassLevel.java:
##########
@@ -52,6 +55,8 @@ public MiniDFSCluster getDfscluster() {
     public void beforeAll(ExtensionContext arg0) throws Exception {
         System.setProperty(TEST_BUILD_DATA, "target/test/data");
         hadoopConf = hadoopConfSupplier.get();
+        String tempDir = getTestDir("dfs").getAbsolutePath() + File.separator;

Review Comment:
   Yes it is related to junit. The getTestDir() in MiniDFSCluster class in Hadoop was using GenericTestUtils (which in turn uses Assert from junit4). This change gets around that by setting the temp dir here instead of relying on GenericTestUtils.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org