You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Manjula Kutty (JIRA)" <ji...@apache.org> on 2008/07/30 22:07:31 UTC
[jira] Created: (DERBY-3808) Convert subquery.sql to junit
Convert subquery.sql to junit
-----------------------------
Key: DERBY-3808
URL: https://issues.apache.org/jira/browse/DERBY-3808
Project: Derby
Issue Type: Bug
Reporter: Manjula Kutty
place holder for converting subquery.sql to junit , which gives intermittent failures with derbyall
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3808) Convert subquery.sql to junit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3808:
----------------------------------
Component/s: Test
> Convert subquery.sql to junit
> -----------------------------
>
> Key: DERBY-3808
> URL: https://issues.apache.org/jira/browse/DERBY-3808
> Project: Derby
> Issue Type: Bug
> Components: Test
> Reporter: Manjula Kutty
> Attachments: DERBY_3808_diff_07_10.txt, DERBY_3808_stat_07_10.txt
>
>
> place holder for converting subquery.sql to junit , which gives intermittent failures with derbyall
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3808) Convert subquery.sql to junit
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty updated DERBY-3808:
---------------------------------
Attachment: DERBY_3808_diff_07_10.txt
DERBY_3808_stat_07_10.txt
Attaching the patch for SubqueryTest.java. This is is the junit conversion of subquery.sql. I didn't include 2 test cases which has Runtimestatistics to check the join order. Me with the help of Kathey Marsden will implement a method for the same in runtimestatistics parser and will include those 2 tests cases later. Please review this patch and if looks good please commit.
> Convert subquery.sql to junit
> -----------------------------
>
> Key: DERBY-3808
> URL: https://issues.apache.org/jira/browse/DERBY-3808
> Project: Derby
> Issue Type: Bug
> Reporter: Manjula Kutty
> Attachments: DERBY_3808_diff_07_10.txt, DERBY_3808_stat_07_10.txt
>
>
> place holder for converting subquery.sql to junit , which gives intermittent failures with derbyall
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3808) Convert subquery.sql to junit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638006#action_12638006 ]
Kathey Marsden commented on DERBY-3808:
---------------------------------------
Thanks Manjula for the patch. Just a few comments.
- Need the license header
- The original test set derby.language.statementCacheSize=0 so we should do that with SystemPropertyTestSetup.
- It would be better to use CleanDatabaseTestSetup/decorateSql for the initial creation of tables and functions so that it doesn't occur with each fixture.
- You can use setAutocommit() and rollback() instead of getConnection().setAutocommit() and getConnection().rollback().
For the new method for RuntimeStatisticsParser, I think something like this should work. (Needs testing and javadoc).
public boolean findOrderedStrings(String[] searchStrings) {
return findOrderedStrings(0,searchStrings);
}
private boolean findOrderedStrings(int start, String[] searchStrings) {
int len = searchStrings.length;
if (searchStrings.length == 0)
return true;
else
{
int offset = statistics.indexOf(searchStrings[0],start);
if (offset == -1)
return false;
String[] newSearchStrings = new String[len -1];
System.arraycopy(searchStrings, 1, newSearchStrings, 0, len-1);
return findOrderedStrings(offset, newSearchStrings);
}
}
> Convert subquery.sql to junit
> -----------------------------
>
> Key: DERBY-3808
> URL: https://issues.apache.org/jira/browse/DERBY-3808
> Project: Derby
> Issue Type: Bug
> Reporter: Manjula Kutty
> Attachments: DERBY_3808_diff_07_10.txt, DERBY_3808_stat_07_10.txt
>
>
> place holder for converting subquery.sql to junit , which gives intermittent failures with derbyall
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3808) Convert subquery.sql to junit
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638015#action_12638015 ]
Manjula Kutty commented on DERBY-3808:
--------------------------------------
Thank you for the comments Kathey. I will look into them and also will try to implement the RuntimeStatisticsParser and will upload a new patch.
> Convert subquery.sql to junit
> -----------------------------
>
> Key: DERBY-3808
> URL: https://issues.apache.org/jira/browse/DERBY-3808
> Project: Derby
> Issue Type: Bug
> Reporter: Manjula Kutty
> Attachments: DERBY_3808_diff_07_10.txt, DERBY_3808_stat_07_10.txt
>
>
> place holder for converting subquery.sql to junit , which gives intermittent failures with derbyall
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.