You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/12 15:34:13 UTC

[GitHub] [kylin] nichunen commented on issue #1150: Kylin-4398 Display Kylin Version on UI

nichunen commented on issue #1150: Kylin-4398 Display Kylin Version on UI
URL: https://github.com/apache/kylin/pull/1150#issuecomment-598254583
 
 
   Hi @sanjulian , thanks for your PR. 
   In your pr, you add a rest api to get the version written as a static variable with name "org.apache.kylin.common.KylinVersion#CURRENT_KYLIN_VERSION". But we can not gurantee it is updated every time for the release, which means the version shown on UI may not be accurate.
   
   Acutually, there is another api with code "org.apache.kylin.rest.controller.AdminController#getKylinVersions", I think the implementation there is more resonable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services