You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/20 09:27:38 UTC
[GitHub] [iotdb] choubenson opened a new pull request, #5610: [IOTDB-2966]fix CompactionTaskManagerTest CI
choubenson opened a new pull request, #5610:
URL: https://github.com/apache/iotdb/pull/5610
See details in [IOTDB-2966](https://issues.apache.org/jira/browse/IOTDB-2966)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5610: [IOTDB-2966]fix CompactionTaskManagerTest CI
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #5610:
URL: https://github.com/apache/iotdb/pull/5610#discussion_r857068965
##########
example/tsfile/src/main/java/org/apache/iotdb/tsfile/TsFileSequenceRead.java:
##########
@@ -46,14 +46,15 @@
/** This tool is used to read TsFile sequentially, including nonAligned or aligned timeseries. */
public class TsFileSequenceRead {
// if you wanna print detailed datas in pages, then turn it true.
- private static boolean printDetail = false;
+ private static boolean printDetail = true;
Review Comment:
recover this
##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java:
##########
@@ -377,16 +377,37 @@ public long getFinishTaskNum() {
@TestOnly
public void restart() throws InterruptedException {
+ long MAX_WAITING_TIME = 120_000L;
Review Comment:
put to a class field: private static final
##########
example/tsfile/src/main/java/org/apache/iotdb/tsfile/TsFileSequenceRead.java:
##########
@@ -46,14 +46,15 @@
/** This tool is used to read TsFile sequentially, including nonAligned or aligned timeseries. */
public class TsFileSequenceRead {
// if you wanna print detailed datas in pages, then turn it true.
- private static boolean printDetail = false;
+ private static boolean printDetail = true;
@SuppressWarnings({
"squid:S3776",
"squid:S106"
}) // Suppress high Cognitive Complexity and Standard outputs warning
public static void main(String[] args) throws IOException {
- String filename = "test.tsfile";
+ String filename =
Review Comment:
recover this
##########
server/src/test/java/org/apache/iotdb/db/engine/compaction/inner/InnerCompactionTest.java:
##########
@@ -160,24 +160,6 @@ void prepareFiles(int seqFileNum, int unseqFileNum) throws IOException, WritePro
unseqResources.add(tsFileResource);
prepareFile(tsFileResource, i * ptNum, ptNum * (i + 1) / unseqFileNum, 10000);
}
-
- File file =
- new File(
- TestConstant.getTestTsFileDir("root.compactionTest", 0, 0)
- .concat(
- unseqFileNum
- + IoTDBConstant.FILE_NAME_SEPARATOR
- + unseqFileNum
- + IoTDBConstant.FILE_NAME_SEPARATOR
- + 0
- + IoTDBConstant.FILE_NAME_SEPARATOR
- + 0
- + ".tsfile"));
- TsFileResource tsFileResource = new TsFileResource(file);
- tsFileResource.setStatus(TsFileResourceStatus.CLOSED);
- tsFileResource.updatePlanIndexes(seqFileNum + unseqFileNum);
- unseqResources.add(tsFileResource);
- prepareFile(tsFileResource, 0, ptNum * unseqFileNum, 20000);
Review Comment:
why delete this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] choubenson commented on a diff in pull request #5610: [IOTDB-2966]fix CompactionTaskManagerTest CI
Posted by GitBox <gi...@apache.org>.
choubenson commented on code in PR #5610:
URL: https://github.com/apache/iotdb/pull/5610#discussion_r854224324
##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java:
##########
@@ -382,11 +382,20 @@ public void restart() throws InterruptedException {
this.taskExecutionPool.shutdownNow();
this.taskExecutionPool.awaitTermination(Long.MAX_VALUE, TimeUnit.MILLISECONDS);
}
+ if (subCompactionTaskExecutionPool != null) {
+ this.subCompactionTaskExecutionPool.shutdownNow();
+ this.subCompactionTaskExecutionPool.awaitTermination(Long.MAX_VALUE, TimeUnit.MILLISECONDS);
Review Comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5610: [IOTDB-2966]fix CompactionTaskManagerTest CI
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #5610:
URL: https://github.com/apache/iotdb/pull/5610#discussion_r854101809
##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java:
##########
@@ -382,11 +382,20 @@ public void restart() throws InterruptedException {
this.taskExecutionPool.shutdownNow();
this.taskExecutionPool.awaitTermination(Long.MAX_VALUE, TimeUnit.MILLISECONDS);
}
+ if (subCompactionTaskExecutionPool != null) {
+ this.subCompactionTaskExecutionPool.shutdownNow();
+ this.subCompactionTaskExecutionPool.awaitTermination(Long.MAX_VALUE, TimeUnit.MILLISECONDS);
Review Comment:
do not wait MAX_VALUE, wait some time then throw exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] choubenson commented on a diff in pull request #5610: [IOTDB-2966]fix CompactionTaskManagerTest CI
Posted by GitBox <gi...@apache.org>.
choubenson commented on code in PR #5610:
URL: https://github.com/apache/iotdb/pull/5610#discussion_r857121762
##########
example/tsfile/src/main/java/org/apache/iotdb/tsfile/TsFileSequenceRead.java:
##########
@@ -46,14 +46,15 @@
/** This tool is used to read TsFile sequentially, including nonAligned or aligned timeseries. */
public class TsFileSequenceRead {
// if you wanna print detailed datas in pages, then turn it true.
- private static boolean printDetail = false;
+ private static boolean printDetail = true;
@SuppressWarnings({
"squid:S3776",
"squid:S106"
}) // Suppress high Cognitive Complexity and Standard outputs warning
public static void main(String[] args) throws IOException {
- String filename = "test.tsfile";
+ String filename =
Review Comment:
Resolved
##########
example/tsfile/src/main/java/org/apache/iotdb/tsfile/TsFileSequenceRead.java:
##########
@@ -46,14 +46,15 @@
/** This tool is used to read TsFile sequentially, including nonAligned or aligned timeseries. */
public class TsFileSequenceRead {
// if you wanna print detailed datas in pages, then turn it true.
- private static boolean printDetail = false;
+ private static boolean printDetail = true;
Review Comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] choubenson commented on a diff in pull request #5610: [IOTDB-2966]fix CompactionTaskManagerTest CI
Posted by GitBox <gi...@apache.org>.
choubenson commented on code in PR #5610:
URL: https://github.com/apache/iotdb/pull/5610#discussion_r857126404
##########
server/src/test/java/org/apache/iotdb/db/engine/compaction/inner/InnerCompactionTest.java:
##########
@@ -160,24 +160,6 @@ void prepareFiles(int seqFileNum, int unseqFileNum) throws IOException, WritePro
unseqResources.add(tsFileResource);
prepareFile(tsFileResource, i * ptNum, ptNum * (i + 1) / unseqFileNum, 10000);
}
-
- File file =
- new File(
- TestConstant.getTestTsFileDir("root.compactionTest", 0, 0)
- .concat(
- unseqFileNum
- + IoTDBConstant.FILE_NAME_SEPARATOR
- + unseqFileNum
- + IoTDBConstant.FILE_NAME_SEPARATOR
- + 0
- + IoTDBConstant.FILE_NAME_SEPARATOR
- + 0
- + ".tsfile"));
- TsFileResource tsFileResource = new TsFileResource(file);
- tsFileResource.setStatus(TsFileResourceStatus.CLOSED);
- tsFileResource.updatePlanIndexes(seqFileNum + unseqFileNum);
- unseqResources.add(tsFileResource);
- prepareFile(tsFileResource, 0, ptNum * unseqFileNum, 20000);
Review Comment:
Because unseq files are created before this, so this code is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] choubenson commented on a diff in pull request #5610: [IOTDB-2966]fix CompactionTaskManagerTest CI
Posted by GitBox <gi...@apache.org>.
choubenson commented on code in PR #5610:
URL: https://github.com/apache/iotdb/pull/5610#discussion_r857126181
##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java:
##########
@@ -377,16 +377,37 @@ public long getFinishTaskNum() {
@TestOnly
public void restart() throws InterruptedException {
+ long MAX_WAITING_TIME = 120_000L;
Review Comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5610: [IOTDB-2966]fix CompactionTaskManagerTest CI
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #5610:
URL: https://github.com/apache/iotdb/pull/5610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org