You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2017/07/27 06:02:12 UTC

logging-log4j2 git commit: [LOG4J2-1991] Refactor SimpleMessage to be concise and clear. Closes #100.

Repository: logging-log4j2
Updated Branches:
  refs/heads/master e0c0a5951 -> 3ed637d29


[LOG4J2-1991] Refactor SimpleMessage to be concise and clear. Closes
#100.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/3ed637d2
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/3ed637d2
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/3ed637d2

Branch: refs/heads/master
Commit: 3ed637d29bf9a5c567120ccc5aad600206174ec8
Parents: e0c0a59
Author: Kenneth McFarland <no...@github.com>
Authored: Wed Jul 26 23:02:04 2017 -0700
Committer: Gary Gregory <gg...@apache.org>
Committed: Wed Jul 26 23:02:04 2017 -0700

----------------------------------------------------------------------
 .../org/apache/logging/log4j/message/SimpleMessage.java  | 11 ++---------
 src/changes/changes.xml                                  |  3 +++
 2 files changed, 5 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3ed637d2/log4j-api/src/main/java/org/apache/logging/log4j/message/SimpleMessage.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/SimpleMessage.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/SimpleMessage.java
index 3e9b70c..8a2fc72 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/message/SimpleMessage.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/message/SimpleMessage.java
@@ -61,19 +61,12 @@ public class SimpleMessage implements Message, StringBuilderFormattable, CharSeq
      */
     @Override
     public String getFormattedMessage() {
-        if (message == null) {
-            message = String.valueOf(charSequence);
-        }
-        return message;
+        return message = message == null ? String.valueOf(charSequence) : message ;
     }
 
     @Override
     public void formatTo(final StringBuilder buffer) {
-        if (message != null) {
-            buffer.append(message);
-        } else {
-            buffer.append(charSequence);
-        }
+	buffer.append(message != null ? message : charSequence);
     }
 
     /**

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/3ed637d2/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index ba23efa..0588360 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -196,6 +196,9 @@
       <action issue="LOG4J2-1294" dev="ggregory" type="add">
         The JMS Appender should use a JMS MapMessage for a Log4j MapMessage.
       </action>
+      <action issue="LOG4J2-1991" dev="ggregory" type="update" due-to="">
+        Refactor SimpleMessage to be concise and clear (#100)
+      </action>
       <action issue="LOG4J2-1868" dev="ggregory" type="update">
         Update ZeroMQ's JeroMQ from 0.3.6 to 0.4.0.
       </action>