You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mikhail Khludnev (JIRA)" <ji...@apache.org> on 2018/10/01 19:54:00 UTC

[jira] [Comment Edited] (SOLR-12798) Structural changes in SolrJ since version 7.0.0 have effectively disabled multipart post

    [ https://issues.apache.org/jira/browse/SOLR-12798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631644#comment-16631644 ] 

Mikhail Khludnev edited comment on SOLR-12798 at 10/1/18 7:53 PM:
------------------------------------------------------------------

[~noble.paul]
-I'm not sure why we need to revamp handlers which expect content stream to manage them to read doc fields. The other concern is that now the request with single content stream works like a mine field, when one adds too long params it blows surprisingly. Always stripping params from POST urls make it way more predictable for users.-   


was (Author: mkhludnev):
[~noble.paul]
I'm not sure why we need to revamp handlers which expect content stream to manage them to read doc fields. The other concern is that now the request with single content stream works like a mine field, when one adds too long params it blows surprisingly. Always stripping params from POST urls make it way more predictable for users.   

> Structural changes in SolrJ since version 7.0.0 have effectively disabled multipart post
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-12798
>                 URL: https://issues.apache.org/jira/browse/SOLR-12798
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: 7.4
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>            Priority: Major
>         Attachments: HOT Balloon Trip_Ultra HD.jpg, SOLR-12798-approach.patch, SOLR-12798-reproducer.patch, SOLR-12798-workaround.patch, SOLR-12798.patch, no params in url.png, solr-update-request.txt
>
>
> Project ManifoldCF uses SolrJ to post documents to Solr.  When upgrading from SolrJ 7.0.x to SolrJ 7.4, we encountered significant structural changes to SolrJ's HttpSolrClient class that seemingly disable any use of multipart post.  This is critical because ManifoldCF's documents often contain metadata in excess of 4K that therefore cannot be stuffed into a URL.
> The changes in question seem to have been performed by Paul Noble on 10/31/2017, with the introduction of the RequestWriter mechanism.  Basically, if a request has a RequestWriter, it is used exclusively to write the request, and that overrides the stream mechanism completely.  I haven't chased it back to a specific ticket.
> ManifoldCF's usage of SolrJ involves the creation of ContentStreamUpdateRequests for all posts meant for Solr Cell, and the creation of UpdateRequests for posts not meant for Solr Cell (as well as for delete and commit requests).  For our release cycle that is taking place right now, we're shipping a modified version of HttpSolrClient that ignores the RequestWriter when dealing with ContentStreamUpdateRequests.  We apparently cannot use multipart for all requests because on the Solr side we get "pfountz Should not get here!" errors on the Solr side when we do, which generate HTTP error code 500 responses.  That should not happen either, in my opinion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org