You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/06/10 23:37:59 UTC
[jira] [Created] (CASSANDRA-2761) drivers do not build
drivers do not build
--------------------
Key: CASSANDRA-2761
URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
Project: Cassandra
Issue Type: Bug
Components: API
Reporter: Jonathan Ellis
Assignee: Eric Evans
Need a way to build the Java driver.
Also: still some vestigal references to drivers/ in trunk build.xml.
Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048343#comment-13048343 ]
Rick Shaw commented on CASSANDRA-2761:
--------------------------------------
Moved from CASSANDRA-2754.
Just a few clarifications as I am not that familiar with the C* infrastructure and build policies etc...
- I'm a Maven guy, but I guess that is out of the question?
- This needs to be Jenkins ready?
- This should build Source and Javadocs artifacts ready for Maven Repo deployment right?
- The resulting JDBC jar file would contain the C* dependancies from the build directory pointed to by the properties file/system property? It would be self contained?
- The testing part of the build is going to have to reach into the C* build area too I think?
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Eric Evans
> Fix For: 1.0
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2761:
--------------------------------------
Affects Version/s: 1.0
Fix Version/s: 1.0
Summary: JDBC driver does not build (was: drivers do not build)
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Eric Evans
> Fix For: 1.0
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082405#comment-13082405 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
Note that CASSANDRA-3010 makes moving drivers out-of-"tree" even sillier: as things stand, we'll need to grab cassandra from the maven repo to build jdbc, then back in tree we'll need to grab jdbc from the maven repo to build the cql shell.
I'm all for purity but at this point I'm ready to just put things back the way they were* so we can spend time before the 1.0 freeze building things instead of wrestling with maven.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090383#comment-13090383 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
bq. I also realize that there is more work needed here to decouple the JDBC driver and make this all work better, work that I've volunteered to do. I haven't had as much time to spend on this lately, but that should be changing RSN.
It's been another two weeks and we're still in this no-man's land where git can't see drivers, the jdbc build is a big TODO, and anything that depends on jdbc like 3010 is basically SOL.
Again, I'm not against purity, but it's clear that the original breaking out of drivers/ was done prematurely (was there even a Jira ticket with a patch? It looks like we went from "that's a good idea" on -dev to ripping apart svn). I've reverted things until the breakout can be done properly.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090481#comment-13090481 ]
T Jake Luciani commented on CASSANDRA-2761:
-------------------------------------------
bq. Our project is (unfortunately )managed in SVN
putting a sub-project in a svn root isn't the way to do it for SVN.
Another issue is the drivers build depends on cassandra. That makes this even more strange. Can't drivers live in /trunk and still have it's own releases?
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090552#comment-13090552 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
bq. One final thought: by coincidence, we broke the JDBC build again today with CASSANDRA-3039. This isn't the first time this has happened. It's a minor win but not negligible to catch those before commit because "ant test" runs both suites.
Broke why? Because of Cassandra code that the driver depends on? That would be an argument in favor of stabalizing the dependent code.
And, the inverse of this is that the drivers should ultimately be getting tested against trunk, each active branch, and all past released versions (limited of course to CQL availability). That is only going to be practical through CI, and is made harder by your monolithic approach.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090502#comment-13090502 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
bq. left people with the expectation that the driver version to use was the one that corresponded to source it was with
I suspect this was when svn was effectively the only way to get a driver. My experience is that even most people building "from source" use a tarball, not svn. So the combination of making drivers available on maven, PyPI, etc., with their own version numbers, should address this.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082457#comment-13082457 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
bq. But we are updating none of those on a daily or weekly basis
I certainly hope we're not updating the JDBC driver that often, particularly in ways that would impact a simple application like a shell.
Our experience using the JDBC driver as an application dependency shouldn't be any better or worse than it would be for other users.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090441#comment-13090441 ]
Rick Shaw commented on CASSANDRA-2761:
--------------------------------------
I don't see any driver code in the move? The {{/driver}} sub-directory now exists but there is nothing underneath?
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050884#comment-13050884 ]
Rick Shaw commented on CASSANDRA-2761:
--------------------------------------
{quote}
What are these 50 other class dependencies? Where are they being drug in?
{quote}
- o.a.c.db.marshall.*
-- 23 various classes
- o.a.c.utils.ByteBufferUtil
-- org.apache.cassandra.io.util.FileDataInput
-- org.apache.cassandra.io.util.FileUtils
- o.a.c.config.ColumnDefinition
- o.a.c.config.CFMetaData
-- org.apache.cassandra.cache.IRowCacheProvider;
-- org.apache.cassandra.db.migration.avro.ColumnDef
-- org.apache.cassandra.db.ColumnFamilyType;
--- org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor
--- org.apache.cassandra.config.DatabaseDescriptor
---- org.apache.cassandra.auth.AllowAllAuthenticator
---- org.apache.cassandra.auth.AllowAllAuthority
---- org.apache.cassandra.auth.IAuthenticator
---- org.apache.cassandra.auth.IAuthority
---- org.apache.cassandra.config.Config.RequestSchedulerId
---- org.apache.cassandra.db.ColumnFamilyStore
----- 13 new items
---- org.apache.cassandra.db.ColumnFamilyType
---- org.apache.cassandra.db.DefsTable
----- org.apache.cassandra.config.DatabaseDescriptor;
----- org.apache.cassandra.config.KSMetaData;
----- org.apache.cassandra.db.filter.QueryFilter;
----- org.apache.cassandra.db.filter.QueryPath;
----- org.apache.cassandra.db.migration.Migration;
----- org.apache.cassandra.io.SerDeUtils;
----- org.apache.cassandra.service.StorageService;
----- org.apache.cassandra.utils.ByteBufferUtil;
----- org.apache.cassandra.utils.UUIDGen;
---- org.apache.cassandra.db.migration.Migration
---- org.apache.cassandra.dht.IPartitioner
---- org.apache.cassandra.io.sstable.Descriptor
---- org.apache.cassandra.io.util.FileUtils
---- org.apache.cassandra.locator.*
---- org.apache.cassandra.scheduler.IRequestSchedule;
---- org.apache.cassandra.scheduler.NoScheduler
--- org.apache.cassandra.db.compaction.CompactionManager
--- org.apache.cassandra.db.filter.QueryFilter
--- org.apache.cassandra.db.filter.QueryPath
--- org.apache.cassandra.dht.IPartitioner
--- org.apache.cassandra.dht.Range
--- org.apache.cassandra.gms.FailureDetector
--- org.apache.cassandra.gms.Gossiper
--- org.apache.cassandra.gms.ApplicationState
--- org.apache.cassandra.net.MessagingService
---- 10 new classes
--- org.apache.cassandra.service.*
--- org.apache.cassandra.utils.WrappedRunnable
-- org.apache.cassandra.db.HintedHandOffManager;
-- org.apache.cassandra.db.SystemTable;
-- org.apache.cassandra.db.Table;
-- org.apache.cassandra.db.ColumnFamilyStore;
-- org.apache.cassandra.db.migration.Migration;
-- org.apache.cassandra.db.compaction.AbstractCompactionStrategy;
-- org.apache.cassandra.io.SerDeUtils;
-- org.apache.cassandra.utils.Pair;
- o.a.c.config.ConfigurationException
The point is there are lots and they are scattered all over the various packages; It will be very difficult to manage when they change from the driver package (client side), which is supposed to be able to change independent of the server code. If a subset of the server code is to be a dependency then that subset (jar/s) must be managed in the main build not the driver build.
{quote}
What would you call such a jar? When I looked at this, there didn't seem to be any delineation that made sense.
{quote}
I agree it is not any clear set of packages. They are scattered all over.
As to a name for the jar... I'm not a good namer in the best of circumstances but I think the intent is to pick those files that are used in common between client and server. I guess I'd use that as the basis for the name.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2761) drivers do not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2761:
--------------------------------------
Description:
Need a way to build (and run tests for) the Java driver.
Also: still some vestigal references to drivers/ in trunk build.xml.
Should we remove drivers/ from the 0.8 branch as well?
was:
Need a way to build the Java driver.
Also: still some vestigal references to drivers/ in trunk build.xml.
Should we remove drivers/ from the 0.8 branch as well?
> drivers do not build
> --------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Eric Evans
> Fix For: 1.0
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082426#comment-13082426 ]
Brandon Williams commented on CASSANDRA-2761:
---------------------------------------------
bq. I'm all for purity but at this point I'm ready to just put things back the way they were* so we can spend time before the 1.0 freeze building things instead of wrestling with maven.
I for one would be delighted if I didn't have to use svn to get at the drivers or cqlsh.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090498#comment-13090498 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
bq. Can't drivers live in /trunk and still have it's own releases?
Right, that seems like the best interim solution to me. (I thought we could even delete it from old branches to make it clear that it's not in lockstep with the rest of the tree, but Eric pointed out that if something like 3010 is depending on it, we can't do that. Still, having it present but "frozen" in the branches feels like a relatively minor downside.)
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082420#comment-13082420 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
The lib/ directory is full of dependency jars, some which exist solely for the cli.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090589#comment-13090589 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
So to summarize: You've decided.
I know that sounds a bit snarky, but you summarily reverted the change, in part based on reasoning that wasn't true (it doesn't build), and in part pending a "reboot" to meet unmeetable requirements.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090719#comment-13090719 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
If waiting for two months of "we'll fix it real soon now" is "summarily," then yeah, I guess guilty as charged.
But it looks like you've restarted discussion on -dev, so I'll move there.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060109#comment-13060109 ]
Rick Shaw commented on CASSANDRA-2761:
--------------------------------------
Sorry. I didn't catch that there was no ant task to RUN them... :) {{build-test}} builds the included tests just fine. And I have been running them from Eclipse once built. I'll look into it.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082428#comment-13082428 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
bq. The lib/ directory is full of dependency jars, some which exist solely for the cli.
But we are updating none of those on a daily or weekly basis.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090417#comment-13090417 ]
Hudson commented on CASSANDRA-2761:
-----------------------------------
Integrated in Cassandra #1045 (See [https://builds.apache.org/job/Cassandra/1045/])
move drivers back in-tree until build issues can be fixed. see CASSANDRA-2761
jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161216
Files :
* /cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
* /cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
* /cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java
* /cassandra/trunk/build.xml
* /cassandra/trunk/contrib
* /cassandra/trunk/drivers/java/README.txt
* /cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java
* /cassandra/trunk/drivers
* /cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java
* /cassandra/trunk
* /cassandra/trunk/drivers/java/build.properties.default
* /cassandra/trunk/drivers/java/build.xml
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048382#comment-13048382 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
bq. I'm a Maven guy, but I guess that is out of the question?
I don't know, but if I were a Maven Guy (I am not), I would use Ant anyway. The vast majority of the active committers wish that Maven would die in a fire, so using it would be the fastest way to engender apathy.
bq. This needs to be Jenkins ready?
Not sure what this means.
bq. This should build Source and Javadocs artifacts ready for Maven Repo deployment right?
Yes.
bq. The resulting JDBC jar file would contain the C* dependancies from the build directory pointed to by the properties file/system property? It would be self contained?
Yes.
bq. The testing part of the build is going to have to reach into the C* build area too I think?
The classpath for tests will probably contain a few additional items that the runtime classpath does not.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Eric Evans
> Fix For: 1.0
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090535#comment-13090535 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
One final thought: by coincidence, we broke the JDBC build again today with CASSANDRA-3039. This isn't the first time this has happened. It's a minor win but not negligible to catch those before commit because "ant test" runs both suites.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082668#comment-13082668 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
bq. Then you're not very familiar with the current stability or lack there of of the JDBC driver.
No, I guess not, but it can't be any worse on us than for anyone else using it. A solution that only benefits us doesn't seem very... friendly.
----
I think the difference in opinion here comes from what determines whether the server and driver should be considered different projects. I can see where people who feel a high degree of ownership over the code of both, and who by virtue of infrastructure have write access to both, might consider it contrived to treat them as separate projects. I'm not discounting that point of view, but I do think that's more Social than Technical, and is limited to a relatively small group of Cassandra hackers.
As I've said elsewhere, I think it is very important that these drivers be allowed to evolve on their own release schedule with their own versioning that reflects compatibility with a CQL version and not any particular Cassandra version(s). It's also quite likely, particularly where the driver language != Java that the group of developers is entirely different from those working on the server. And there is no hard dependency between drivers and Cassandra in either direction (the JDBC->Cassandra dependency is one of convenience). To me, this pretty solidly points to them being separate projects.
Keeping them separate won't be as convenient as treating them as one monolithic project, but it's no worse an experience than what other application developers are subjected to. We should be able to eat our own dog food.
I also realize that there is more work needed here to decouple the JDBC driver and make this all work better, work that I've volunteered to do. I haven't had as much time to spend on this lately, but that should be changing RSN.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060081#comment-13060081 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
What's the status here? Not having "ant test" for the drivers anymore is causing me pain and suffering. :(
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090445#comment-13090445 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
https://svn.apache.org/repos/asf/cassandra/trunk/drivers/
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048738#comment-13048738 ]
Rick Shaw commented on CASSANDRA-2761:
--------------------------------------
Thanks Eric.
Actually you list is the same as mine so we are probably close. Note you will still need the whole C*-Thrift jar. I will build a new driver with the additional classes and test it without depending on the full C*. I'll document the full dependancy list here along with the next patch.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065026#comment-13065026 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
Attached (v1-0001-CASSANDRA-2761-cleanup-nits.txt) is a patch to do a little cleanup (clearer variable naming, some simplification of classpaths, etc), basically stuff that set my OCD off and seemed better to get in *before* diving into test running and dependency management.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069248#comment-13069248 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
To summarize, it is now possible to build and test w/ ant. This is currently done by pointing to a local (built) working copy of Cassandra (a site config). What's left, and seems reasonable to scope with this issue:
* Create an alternate mechanism for specifying the version of Cassandra to build/test against (in order to run the tests against prior releases). I'm thinking Ivy could be used here to automatically download artifacts when a property is passed (-Dcassandra.release=0.8.0 for example).
* (Re)build Cassandra as needed from the drivers Ant build, or at the very least, handle the case when a build is needed.
* Fix the {{generate-eclipse-files}} target if possible, or remove it otherwise.
Work should also continue to reduce the cross-section of Cassandra that this driver depends on, but I'll open another issue for that.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Shaw updated CASSANDRA-2761:
---------------------------------
Attachment: jdbc-driver-build-v2.txt
The v2 patch adds inclusion of classes that are required on the client side from the main C* build.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, jdbc-driver-build-v2.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048740#comment-13048740 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
bq. Note you will still need the whole C*-Thrift jar.
Yeah, but don't copy those. The driver jar will need to depend on the thrift jar.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Shaw updated CASSANDRA-2761:
---------------------------------
Attachment: (was: jdbc-driver-build-v2.txt)
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050534#comment-13050534 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
{quote}
I can try an get them all in but I think we should seriously rethink that strategy for now. With this many dependancies they should probably be put in their own jar(s). It would really make the driver jar have to keep up with detailed dependency changes in the server code base. Miss one and it's messy and the errors are non-obvious.
{quote}
What would you call such a jar? When I looked at this, there didn't seem to be any delineation that made sense.
{quote}
I was a big whiner about not carrying around the whole server just for client access, but until it is re-factored, I can now appreciate the horror that will commence if we piece-meal drag over classes from the server into the JAR.
{quote}
What are these 50 other class dependencies? Where are they being drug in?
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090464#comment-13090464 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
{quote}
It's been another two weeks and we're still in this no-man's land where git can't see drivers
{quote}
So does this mean you've decided Git is hard a requirement? Our project is (unfortunately )managed in SVN. You know if it were up to me we'd be using Git for source control, but it's not up to me and we don't.
{quote}
...anything that depends on jdbc like 3010 is basically SOL.
{quote}
As I've already mentioned, CASSANDAR-3010 is for a JDBC using _application_. If it's SOL unless the driver is embedded in the tree, then so is every other application that would make use of the driver. If the driver is so bad, maybe no one should be using it. Why are we giving ourselves special treatment?
{quote}
Again, I'm not against purity...
{quote}
By saying "purity" it sounds like you're dismissing it as something that's based on aesthetics. I assure that's not the case, it's about avoiding the inevitable lock-step relationship release-wise.
{quote}
...but it's clear that the original breaking out of drivers/ was done prematurely (was there even a Jira ticket with a patch?
{quote}
There was a Jira yes, though I'm pretty sure it done as part of larger set of tasks, something with a description other than "relocate drivers out of tree". And, I don't think it was in a patch, no, due to the fact that a large move with some minor changes was (a) straightforward, and (b) would have needed rebasing several times a day.
{quote}
It looks like we went from "that's a good idea" on -dev to ripping apart svn). I've reverted things until the breakout can be done properly.
{quote}
So all I need to do is find a ticket and a +1 and I can -1 this, and revert your revert?
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090724#comment-13090724 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
Up until the July 21st, the scope of the ticket was building and running the unit tests (and as of July 21st that much was working). It wasn't until Aug 10th (and the creation of CASSANDRA-3010) that the discussion (and scope) changed. Between the 10th and today there was no response to my last, then 4 hours after Jake's comment the revert was made.
I already told you once today that I ascribed no malice in this, and I don't, but I think "summarily" is a fair assessment.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090521#comment-13090521 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
bq. people's expectation will always be that the version they need is the one that came with their software
I don't understand. What version will "come with their [server]?"
Consider postgresql: the server is distributed on postgresql.org, and psycopg is distributed over PyPI. Nobody gets confused about staying on an obsolete version of psycopg.
That's the model I see us moving towards. (As you know, we recently got the Python cql driver on PyPI.)
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082495#comment-13082495 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
bq. I certainly hope we're not updating the JDBC driver that often
Then you're not very familiar with the current stability or lack there of of the JDBC driver. :)
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090196#comment-13090196 ]
T Jake Luciani commented on CASSANDRA-2761:
-------------------------------------------
Is their someway to get a git repo for just drivers? like cassandra.git but cassandra-drivers.git? This is causing major pain.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069317#comment-13069317 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
+1 cleanup patch
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-2761.
---------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.0)
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090501#comment-13090501 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
How do we reboot and do it right? Your requirements as I understand them are structured in such a way that keeping them in-tree is the only solution.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049983#comment-13049983 ]
Rick Shaw commented on CASSANDRA-2761:
--------------------------------------
I put together a patch that covered the obvious but I had strange problems in test. So I dug deeper and found a ton (over 50 I think) additional transitive dependencies that I had missed... (silly me)
I can try an get them all in but I think we should seriously rethink that strategy for now. With this many dependancies they should probably be put in their own jar(s). It would really make the driver jar have to keep up with detailed dependency changes in the server code base. Miss one and it's messy and the errors are non-obvious.
I was a big whiner about not carrying around the whole server just for client access, but until it is re-factored, I can now appreciate the horror that will commence if we piece-meal drag over classes from the server into the JAR.
So fo now I suggest we keep the jar the way it is with just the o.a.c.cql.jdbc.* classes.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090494#comment-13090494 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
bq. There was a Jira yes
I couldn't find one, and the svn commit messages didn't mention it. I still can't find one.
bq. So all I need to do is find a ticket and a +1 and I can -1 this, and revert your revert?
The point of making a ticket with a patch (or a shell script if you're throwing svn refactoring around -- you can do mv's from a working copy, not just on the repository, btw) is that people can review it and see if the result matches what they thought they were going to get out of it. In this case it's clear that it didn't, and we ended up with making things worse in exchange for a promise to clean it up eventually.
(Of course, even with proper review, sometimes we've needed to revert things after unexpected problems arose. But skipping the review makes that more likely.)
It's been *over two months.* So let's reboot, and do it right. Note that this time around I got everything in one commit (well, one for trunk, and one for drivers) so "reverting the revert" will be easy.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048734#comment-13048734 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
Thanks Rick, this is a good start, and a lot better than having no build at all, so I went ahead and committed it.
I made a fewer minor changes (mostly replacing tabs for spaces), so you'll need to rebase against svn before continuing.
bq. I will update when a few more clarifications of exactly what dependancies we want to declare for the driver and what we want to include in the jar.
There is probably some handy tool for this, but I don't know what it is. Just looking at it I'd say you need to copy-in:
* {{o.a.c.db.marshall.*}}
* {{o.a.c.utils.ByteBufferUtil}}
* {{o.a.c.config.ColumnDefinition}}
* {{o.a.c.config.CFMetaData}}
* {{o.a.c.config.ConfigurationException}}
There might be some transitive dependencies though.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Eric Evans
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-2761) JDBC driver does not
build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069353#comment-13069353 ]
Rick Shaw edited comment on CASSANDRA-2761 at 7/22/11 2:08 AM:
---------------------------------------------------------------
+1 for the cleanup patch
The {{generate-eclipse-files}} seems to be working for me? How does it fail?
was (Author: ardot):
+1 for the cleanup path
The {{generate-eclipse-files}} seems to be working for me? How does it fail?
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-2761:
----------------------------------
Attachment: v1-0001-CASSANDRA-2761-cleanup-nits.txt
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-2761:
----------------------------------
Reviewer: urandom
Assignee: Rick Shaw (was: Eric Evans)
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090544#comment-13090544 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
{quote}
I don't understand. What version will "come with their [server]?"
{quote}
Wherever we publish the source, be it an SVN checkout with an SVN revision ID, a date-based development snapshot, or a full-on release artifact, if there is driver source contained within then people are going to be encouraged to think of those drivers as being the same version as the node (e.g. 0.8.9). They're also going to be encouraged to think that those drivers are the best choice to use with the corresponding node. It's futile to think they won't, and having other vectors (www.a.o, PyPI, etc), will only add to the confusion.
{quote}
Consider postgresql: the server is distributed on postgresql.org, and psycopg is distributed over PyPI. Nobody gets confused about staying on an obsolete version of psycopg.
That's the model I see us moving towards. (As you know, we recently got the Python cql driver on PyPI.)
{quote}
You make an excellent point. Pyscopg is maintained in a completely different repository (git://luna.dndg.it/public/psycopg2.git) than Postgesql (git://git.postgresql.org/git/postgresql.git) and is released (and published) separately, (which is in fact consistent with best practice elsewhere).
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090497#comment-13090497 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
bq. putting a sub-project in a svn root isn't the way to do it for SVN.
What is?
bq. Another issue is the drivers build depends on cassandra. That makes this even more strange. Can't drivers live in /trunk and still have it's own releases?
We had it that way originally. It made releasing a pain, and left people with the expectation that the driver version to use was the one that corresponded to source it was with (which is unavoidable).
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090557#comment-13090557 ]
Jonathan Ellis commented on CASSANDRA-2761:
-------------------------------------------
bq. if there is driver source contained
Almost all non-developers get the source from a release tarball, not svn. Do we publish drivers/ in the source tarballs? If so that's easy enough to fix.
Anyone actually using svn I'm willing to educate. You can give them my email. :)
bq. Pyscopg is maintained in a completely different repository
But as far as users are concerned that is irrelevant.
If you want examples of drivers in the same tree that are also not causing confusion, I can point you to https://github.com/mongodb/mongo and https://github.com/mongodb/mongo/tree/master/client. Also http://hg.basho.com/riak/src/5ffa6ae7e699 (http://hg.basho.com/riak/src/5ffa6ae7e699/client_lib/) and https://github.com/voldemort/voldemort (https://github.com/voldemort/voldemort/tree/master/clients).
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090505#comment-13090505 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
bq. Right, that seems like the best interim solution to me. (I thought we could even delete it from old branches to make it clear that it's not in lockstep with the rest of the tree, but Eric pointed out that if something like 3010 is depending on it, we can't do that. Still, having it present but "frozen" in the branches feels like a relatively minor downside.)
Except that people's expectation will always be that the version they need is the one that came with their software (which will likely be something pre-release). It is completely unrealistic to expect folks to just Know Better here.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069353#comment-13069353 ]
Rick Shaw commented on CASSANDRA-2761:
--------------------------------------
+1 for the cleanup path
The {{generate-eclipse-files}} seems to be working for me? How does it fail?
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt, v1-0001-CASSANDRA-2761-cleanup-nits.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2761) JDBC driver does not build
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051138#comment-13051138 ]
Eric Evans commented on CASSANDRA-2761:
---------------------------------------
{quote}
The point is there are lots and they are scattered all over the various packages; It will be very difficult to manage when they change from the driver package (client side), which is supposed to be able to change independent of the server code. If a subset of the server code is to be a dependency then that subset (jar/s) must be managed in the main build not the driver build.
{quote}
Right, I was curious to see the list of classes (that list is fantastic btw, thanks for that), to see if there was one point in the graph where breaking a dependency would drastically change the scope of the problem. It looks like the answer is Yes, and the dependency is {{o.a.c.config.CFMetaData}}, (needed by {{ColumnDecoder}}).
Just skimming through the code, I don't think it would be hard to either re-implement the needed parts of CFMetaData, or refactor CFMetaData to limit what it pulled in.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Rick Shaw
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2761) JDBC driver does not build
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Shaw updated CASSANDRA-2761:
---------------------------------
Attachment: jdbc-driver-build-v1.txt
OK, Patch for an ANT Build for the JDBC Driver suite is attached.
It builds all the artifacts, but at the moment it does NOT include any other classes but the ones in the o.a.c.cql.jdbc package.
I will update when a few more clarifications of exactly what dependancies we want to declare for the driver and what we want to include in the jar.
I think I got the Eclipse stuff in ther as well, but that could probably use some wringing out.. I was able to successfully run the junit tests from Eclipse.
> JDBC driver does not build
> --------------------------
>
> Key: CASSANDRA-2761
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2761
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0
> Reporter: Jonathan Ellis
> Assignee: Eric Evans
> Fix For: 1.0
>
> Attachments: jdbc-driver-build-v1.txt
>
>
> Need a way to build (and run tests for) the Java driver.
> Also: still some vestigal references to drivers/ in trunk build.xml.
> Should we remove drivers/ from the 0.8 branch as well?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira