You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/05/18 04:35:41 UTC

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6918

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/server/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
11 files changed, 165 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/6918

to look at the new patch set (#6).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/default-path-handlers.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
14 files changed, 195 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/6
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-Change-Number: 6918
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/6918

to look at the new patch set (#10).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/client/CMakeLists.txt
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/tcmalloc_metrics.cc
M src/kudu/server/webserver-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
18 files changed, 222 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/10
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-Change-Number: 6918
Gerrit-PatchSet: 10
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6918

to look at the new patch set (#3).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/server/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
11 files changed, 168 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/6918

to look at the new patch set (#4).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
13 files changed, 173 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-Change-Number: 6918
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/6918

to look at the new patch set (#9).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/client/CMakeLists.txt
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/tcmalloc_metrics.cc
M src/kudu/server/webserver-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
18 files changed, 211 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/9
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-Change-Number: 6918
Gerrit-PatchSet: 9
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/6918 )

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................


Abandoned

With recent bug fixes in tcmalloc I think this isn't worth pursuing in the near or medium term
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-Change-Number: 6918
Gerrit-PatchSet: 10
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/6918

to look at the new patch set (#7).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/webserver-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
15 files changed, 203 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/7
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-Change-Number: 6918
Gerrit-PatchSet: 7
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Todd Lipcon has posted comments on this change.

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................


Patch Set 3:

futzed with this for a few minutes. Looks like it's necessary that libjemalloc be listed first on the linker invocation (before test_main.so). Need to convince cmake to do that

-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Todd Lipcon has uploaded a new patch set (#2).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/server/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
11 files changed, 165 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/6918

to look at the new patch set (#8).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/tcmalloc_metrics.cc
M src/kudu/server/webserver-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
17 files changed, 208 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/8
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-Change-Number: 6918
Gerrit-PatchSet: 8
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/6918

to look at the new patch set (#5).

Change subject: WIP: KUDU-1366: allow building against jemalloc
......................................................................

WIP: KUDU-1366: allow building against jemalloc

This adds jemalloc to thirdparty and hooks it up for process memory accounting.
I also did a couple little jemalloc-specific optimizations in faststring.

WIP because it needs benchmarking to see if this is truly a win.

Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
---
M CMakeLists.txt
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/default-path-handlers.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/faststring-test.cc
M src/kudu/util/faststring.cc
M src/kudu/util/malloc.h
M src/kudu/util/process_memory.cc
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
14 files changed, 183 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/6918/5
-- 
To view, visit http://gerrit.cloudera.org:8080/6918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59f77e9f1ebdf6f1451e0f723a91cda4790c434b
Gerrit-Change-Number: 6918
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>