You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2025/07/15 14:06:38 UTC
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23175
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
IMPALA-14138: Manually disable block location loading via Hadoop config
For storage systems that support block location information (HDFS,
Ozone) we always retrieve it with the assumption that we can use it for
scheduling, to do local reads. But it's also typical that Impala is not
co-located with the storage system, not even in on-prem deployments.
E.g. when Impala runs in containers, and even if they are co-located,
we don't try to figure out which container runs on which machine.
In such cases we should not reach out to the storage system to collect
file information because it can be very expensive for large tables and
we won't benefit from it at all. Since currently there is no easy way
to tell if Impala is co-located with the storage system this patch
adds configuration options to disable block location retrieval during
table loading.
It can be disabled globally via Hadoop Configuration:
'impala.preload-block-locations-for-scheduling': 'false'
We can restrict it to filesystem schemes, e.g.:
'impala.preload-block-locations-for-scheduling.scheme.hdfs': 'false'
When multiple storage systems are configured with the same scheme, we
can still also control block location loading based on authority, e.g.:
'impala.preload-block-locations-for-scheduling.authority.mycluster': 'false'
The latter only disables block location loading for URIs like
'hdfs://mycluster/warehouse/tablespace/...'
Testing:
* added unit tests for FileSystemUtil
* added unit tests for the file metadata loaders
* custom cluster tests with custom Hadoop configuration
Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
---
M bin/create-test-configuration.sh
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
A testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test
M tests/common/custom_cluster_test_suite.py
A tests/custom_cluster/test_disabled_block_locations.py
8 files changed, 296 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/23175/1
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23175
to look at the new patch set (#2).
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
IMPALA-14138: Manually disable block location loading via Hadoop config
For storage systems that support block location information (HDFS,
Ozone) we always retrieve it with the assumption that we can use it for
scheduling, to do local reads. But it's also typical that Impala is not
co-located with the storage system, not even in on-prem deployments.
E.g. when Impala runs in containers, and even if they are co-located,
we don't try to figure out which container runs on which machine.
In such cases we should not reach out to the storage system to collect
file information because it can be very expensive for large tables and
we won't benefit from it at all. Since currently there is no easy way
to tell if Impala is co-located with the storage system this patch
adds configuration options to disable block location retrieval during
table loading.
It can be disabled globally via Hadoop Configuration (if so, the other
configurations (about schemes and authorities) are ignored):
'impala.preload-block-locations-for-scheduling': 'false'
We can restrict it to filesystem schemes, e.g.:
'impala.preload-block-locations-for-scheduling.scheme.hdfs': 'false'
When multiple storage systems are configured with the same scheme, we
can still also control block location loading based on authority, e.g.:
'impala.preload-block-locations-for-scheduling.authority.mycluster': 'false'
The latter only disables block location loading for URIs like
'hdfs://mycluster/warehouse/tablespace/...'
Testing:
* added unit tests for FileSystemUtil
* added unit tests for the file metadata loaders
* custom cluster tests with custom Hadoop configuration
Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
---
M bin/create-test-configuration.sh
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
A testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test
M tests/common/custom_cluster_test_suite.py
A tests/custom_cluster/test_disabled_block_locations.py
8 files changed, 295 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/23175/2
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:
http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@583
PS2, Line 583: return SCHEME_SUPPORT_STORAGE_IDS.contains(fs.getScheme()) &&
: PRELOAD_BLOCK_LOCATIONS_FOR_SCHEDULING &&
: !NO_BLOCK_LOCATIONS_FOR_FS_SCHEMES.contains(fs.getScheme()) &&
These could be simplified to a single set, which is empty if PRELOAD_BLOCK_LOCATIONS_FOR_SCHEDULING is false
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 13:48:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 15:44:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 4: Code-Review+2
Carrying +1 from Daniel and Csaba.
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 05:06:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19879/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jul 2025 14:33:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 13:08:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
IMPALA-14138: Manually disable block location loading via Hadoop config
For storage systems that support block location information (HDFS,
Ozone) we always retrieve it with the assumption that we can use it for
scheduling, to do local reads. But it's also typical that Impala is not
co-located with the storage system, not even in on-prem deployments.
E.g. when Impala runs in containers, and even if they are co-located,
we don't try to figure out which container runs on which machine.
In such cases we should not reach out to the storage system to collect
file information because it can be very expensive for large tables and
we won't benefit from it at all. Since currently there is no easy way
to tell if Impala is co-located with the storage system this patch
adds configuration options to disable block location retrieval during
table loading.
It can be disabled globally via Hadoop Configuration:
'impala.preload-block-locations-for-scheduling': 'false'
We can restrict it to filesystem schemes, e.g.:
'impala.preload-block-locations-for-scheduling.scheme.hdfs': 'false'
When multiple storage systems are configured with the same scheme, we
can still control block location loading based on authority, e.g.:
'impala.preload-block-locations-for-scheduling.authority.mycluster': 'false'
The latter only disables block location loading for URIs like
'hdfs://mycluster/warehouse/tablespace/...'
If block location loading is disabled by any of the switches, it cannot
be re-enabled by another, i.e. the most restrictive setting prevails.
E.g:
disable scheme 'hdfs', enable authority 'mycluster'
==> hdfs://mycluster/ is still disabled
disable globally, enable scheme 'hdfs', enable authority 'mycluster'
==> hdfs://mycluster/ is still disabled, as everything else is.
Testing:
* added unit tests for FileSystemUtil
* added unit tests for the file metadata loaders
* custom cluster tests with custom Hadoop configuration
Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Reviewed-on: http://gerrit.cloudera.org:8080/23175
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/create-test-configuration.sh
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
A testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test
M tests/common/custom_cluster_test_suite.py
A tests/custom_cluster/test_disabled_block_locations.py
8 files changed, 294 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19894/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 15:14:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12193/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 06:58:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG@25
PS1, Line 25:
> Yes, it is a big hammer to completely disable block location loading effici
I agree we don't need to make it more sophisticated.
This is also true with schemes and authorities, if something is disabled with schemes we can't re-enable it through authorities (e.g. no block-location loading on HDFS except on 'mycluster'). So instead of saying the global config overrides the others, we could say something like if block-location loading is disabled by any of the switches, it cannot be re-enabled by another, i.e. the most restrictive setting prevails.
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 09:47:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 15:22:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 3:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23175/3/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:
http://gerrit.cloudera.org:8080/#/c/23175/3/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@581
PS3, Line 581: LOG.info(String.format("BLOCK_LOCATIONS_FOR_FS_SCHEMES = %s, NO_BLOCK_LOCATIONS_FOR_AUTHORITIES = %s",
line too long (106 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 14:47:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 06:58:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG@25
PS1, Line 25: 'impala.preload-block-locations-for-scheduling': 'false'
Is there any valid use case for setting these configs to "true"? As far as I understand it, if 'impala.preload-block-locations-for-scheduling' is set to false, even if we set e.g. 'impala.preload-block-locations-for-scheduling.authority.mycluster' to true it will not have any effect.
If true, I think we should mention it here.
http://gerrit.cloudera.org:8080/#/c/23175/1/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:
http://gerrit.cloudera.org:8080/#/c/23175/1/bin/create-test-configuration.sh@138
PS1, Line 138: export CORE_SITE_VARIANT=disable_block_locations
Shouldn't we reset this env var for future safety? Or instead of exporting it, just use it for the command?
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Jul 2025 14:27:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 2:
(2 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG@25
PS1, Line 25:
> Is there any valid use case for setting these configs to "true"? As far as
Yes, it is a big hammer to completely disable block location loading efficiently. We could make it more sophisticated, e.g.:
global < scheme < authority
But I don't think it's necessary to complicate the logic as there'll be only 1-3 storage systems configured at most, realistically, so it should be easy to configure them.
I'll also create a follow-up doc Jira once this CR finalizes.
http://gerrit.cloudera.org:8080/#/c/23175/1/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:
http://gerrit.cloudera.org:8080/#/c/23175/1/bin/create-test-configuration.sh@138
PS1, Line 138: CORE_SITE_VARIANT=disable_block_locations $IMPALA_HOME/bin/generate_xml_config.py \
> Shouldn't we reset this env var for future safety? Or instead of exporting
Good idea, I went with the latter.
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 09:14:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23175
to look at the new patch set (#3).
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
IMPALA-14138: Manually disable block location loading via Hadoop config
For storage systems that support block location information (HDFS,
Ozone) we always retrieve it with the assumption that we can use it for
scheduling, to do local reads. But it's also typical that Impala is not
co-located with the storage system, not even in on-prem deployments.
E.g. when Impala runs in containers, and even if they are co-located,
we don't try to figure out which container runs on which machine.
In such cases we should not reach out to the storage system to collect
file information because it can be very expensive for large tables and
we won't benefit from it at all. Since currently there is no easy way
to tell if Impala is co-located with the storage system this patch
adds configuration options to disable block location retrieval during
table loading.
It can be disabled globally via Hadoop Configuration:
'impala.preload-block-locations-for-scheduling': 'false'
We can restrict it to filesystem schemes, e.g.:
'impala.preload-block-locations-for-scheduling.scheme.hdfs': 'false'
When multiple storage systems are configured with the same scheme, we
can still control block location loading based on authority, e.g.:
'impala.preload-block-locations-for-scheduling.authority.mycluster': 'false'
The latter only disables block location loading for URIs like
'hdfs://mycluster/warehouse/tablespace/...'
If block location loading is disabled by any of the switches, it cannot
be re-enabled by another, i.e. the most restrictive setting prevails.
E.g:
disable scheme 'hdfs', enable authority 'mycluster'
==> hdfs://mycluster/ is still disabled
disable globally, enable scheme 'hdfs', enable authority 'mycluster'
==> hdfs://mycluster/ is still disabled, as everything else is.
Testing:
* added unit tests for FileSystemUtil
* added unit tests for the file metadata loaders
* custom cluster tests with custom Hadoop configuration
Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
---
M bin/create-test-configuration.sh
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
A testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test
M tests/common/custom_cluster_test_suite.py
A tests/custom_cluster/test_disabled_block_locations.py
8 files changed, 296 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/23175/3
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 3:
(4 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:
http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@583
PS2, Line 583: return BLOCK_LOCATIONS_FOR_FS_SCHEMES.contains(fs.getScheme()) &&
: !NO_BLOCK_LOCATIONS_FOR_AUTHORITIES.contains(fs.getUri().getAuthority());
: }
> These could be simplified to a single set, which is empty if PRELOAD_BLOCK_
Good idea, done.
http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
File fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java:
http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@46
PS2, Line 46: public class FileMetadataLoaderTest {
> nit: unused import
Done
http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test
File testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test:
http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test@28
PS2, Line 28: # 'lineitem_sixblocks' contains a single data file with six HDFS blocks. Without
> nit: please mention that this table just have a single file.
Done
http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test@35
PS2, Line 35: ---- RUNTIME_PROFILE
> nit: please comment that this is matching the ExecSummary section of the pr
Done. Also fixed the expression to be the same as L45.
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 14:46:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
The patch looks pretty good!
http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
File fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java:
http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@46
PS2, Line 46: import org.opensaml.xmlsec.signature.P;
nit: unused import
http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test
File testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test:
http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test@28
PS2, Line 28: # Without block information we schedule the whole data file to a single SCAN operator.
nit: please mention that this table just have a single file.
http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test@35
PS2, Line 35: row_regex: 00:SCAN [A-Z0-9]+[ ]+1[ ]+1[ ]+.*
nit: please comment that this is matching the ExecSummary section of the profile. I thought it's in the query plan so got confused at the begining.
Is it intented to be different than the expression on L45?
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 10:58:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19893/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 15:12:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23175
to look at the new patch set (#4).
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
IMPALA-14138: Manually disable block location loading via Hadoop config
For storage systems that support block location information (HDFS,
Ozone) we always retrieve it with the assumption that we can use it for
scheduling, to do local reads. But it's also typical that Impala is not
co-located with the storage system, not even in on-prem deployments.
E.g. when Impala runs in containers, and even if they are co-located,
we don't try to figure out which container runs on which machine.
In such cases we should not reach out to the storage system to collect
file information because it can be very expensive for large tables and
we won't benefit from it at all. Since currently there is no easy way
to tell if Impala is co-located with the storage system this patch
adds configuration options to disable block location retrieval during
table loading.
It can be disabled globally via Hadoop Configuration:
'impala.preload-block-locations-for-scheduling': 'false'
We can restrict it to filesystem schemes, e.g.:
'impala.preload-block-locations-for-scheduling.scheme.hdfs': 'false'
When multiple storage systems are configured with the same scheme, we
can still control block location loading based on authority, e.g.:
'impala.preload-block-locations-for-scheduling.authority.mycluster': 'false'
The latter only disables block location loading for URIs like
'hdfs://mycluster/warehouse/tablespace/...'
If block location loading is disabled by any of the switches, it cannot
be re-enabled by another, i.e. the most restrictive setting prevails.
E.g:
disable scheme 'hdfs', enable authority 'mycluster'
==> hdfs://mycluster/ is still disabled
disable globally, enable scheme 'hdfs', enable authority 'mycluster'
==> hdfs://mycluster/ is still disabled, as everything else is.
Testing:
* added unit tests for FileSystemUtil
* added unit tests for the file metadata loaders
* custom cluster tests with custom Hadoop configuration
Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
---
M bin/create-test-configuration.sh
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
A testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test
M tests/common/custom_cluster_test_suite.py
A tests/custom_cluster/test_disabled_block_locations.py
8 files changed, 294 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/23175/4
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12186/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 09:14:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14138: Manually disable block location loading via Hadoop config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19888/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 09:41:04 +0000
Gerrit-HasComments: No