You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jason Dillon <ja...@planet57.com> on 2007/04/15 22:39:53 UTC
Re: svn commit: r528976 - in /geronimo/devtools/maven-plugins/trunk: maven-eclipse-plugin/ maven-geronimodevtools-plugin/
Yikes dude... having another maven-eclipse-plugin, or (eclipse-maven-
plugin for that matter) is going to cause problems when one executes
`mvn eclipse:<goal>` in a project that has these configured.
And actually... why is this needed?
--jason
On Apr 15, 2007, at 6:51 AM, sppatel@apache.org wrote:
> Author: sppatel
> Date: Sun Apr 15 06:51:32 2007
> New Revision: 528976
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=528976
> Log:
> rename plugin
>
> Added:
> geronimo/devtools/maven-plugins/trunk/maven-eclipse-plugin/
> - copied from r528975, geronimo/devtools/maven-plugins/trunk/
> maven-geronimodevtools-plugin/
> Removed:
> geronimo/devtools/maven-plugins/trunk/maven-geronimodevtools-
> plugin/
>
Re: svn commit: r528976 - in /geronimo/devtools/maven-plugins/trunk: maven-eclipse-plugin/ maven-geronimodevtools-plugin/
Posted by Sachin Patel <sp...@gmail.com>.
Here is some more info on maven & the eclipse team working to better
support eclipse plugin builds.
http://docs.codehaus.org/display/MAVEN/Barriers+to+Building+Eclipse
+with+Maven
-sachin
On Apr 15, 2007, at 6:20 PM, Sachin Patel wrote:
> These maven plugins are needed into order to build "eclipse-
> plugins". I extracted them out for use with J2G. Maven's eclipse
> plugin has made significant improvements since I initially created
> these plugins, but they still don't address many issues that are
> needed to build "eclipse plugins" or I don't like the way maven
> provides a solution to some of the issues that my plugins handle
> better.
>
> See...
>
> http://www.eclipse.org/articles/article.php?file=Article-Eclipse-
> and-Maven2/index.html.
>
> Also, there is no conflict with maven's eclipse plugin and this
> one. So eclipse:goal still fine.
>
> -sachin
>
>
> On Apr 15, 2007, at 4:39 PM, Jason Dillon wrote:
>
>> Yikes dude... having another maven-eclipse-plugin, or (eclipse-
>> maven-plugin for that matter) is going to cause problems when one
>> executes `mvn eclipse:<goal>` in a project that has these configured.
>>
>> And actually... why is this needed?
>>
>> --jason
>>
>>
>> On Apr 15, 2007, at 6:51 AM, sppatel@apache.org wrote:
>>
>>> Author: sppatel
>>> Date: Sun Apr 15 06:51:32 2007
>>> New Revision: 528976
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=528976
>>> Log:
>>> rename plugin
>>>
>>> Added:
>>> geronimo/devtools/maven-plugins/trunk/maven-eclipse-plugin/
>>> - copied from r528975, geronimo/devtools/maven-plugins/
>>> trunk/maven-geronimodevtools-plugin/
>>> Removed:
>>> geronimo/devtools/maven-plugins/trunk/maven-geronimodevtools-
>>> plugin/
>>>
>>
>
Re: svn commit: r528976 - in /geronimo/devtools/maven-plugins/trunk: maven-eclipse-plugin/ maven-geronimodevtools-plugin/
Posted by Sachin Patel <sp...@gmail.com>.
Ok, I can rename it again. :) How about maven-eclipsepde-plugin?
The pde-maven-plugin basically wraps the Eclipse-PDE-Builder. So
using it would be essentially unmavenizing it, and would require ant
scripts to configure the eclipse pde builder, and then eclipse itself
would be building the plugins and features, not maven. Using it
would be a regression in my mind and a huge step back from even what
Maven currently has and is working to provide.
-sachin
On Apr 15, 2007, at 7:15 PM, Jason Dillon wrote:
> On Apr 15, 2007, at 3:20 PM, Sachin Patel wrote:
>> These maven plugins are needed into order to build "eclipse-
>> plugins". I extracted them out for use with J2G. Maven's eclipse
>> plugin has made significant improvements since I initially created
>> these plugins, but they still don't address many issues that are
>> needed to build "eclipse plugins" or I don't like the way maven
>> provides a solution to some of the issues that my plugins handle
>> better.
>
> Ya, I know the eclipse plugin has some faults. Though it would be
> nice to see us not need this custom plugin and get the changes
> needed merged into the official plugin. By the way, have you
> looked at the pde-maven-plugin ( http://mojo.codehaus.org/pde-maven-
> plugin/ )?
>
>
>> See...
>>
>> http://www.eclipse.org/articles/article.php?file=Article-Eclipse-
>> and-Maven2/index.html.
>>
>> Also, there is no conflict with maven's eclipse plugin and this
>> one. So eclipse:goal still fine.
>
> That is not true... or I would not have mentioned it... its not
> like I just started using Maven 2 yesterday :-P
>
> Your plugin will also get bound with the prefix "eclipse" due to
> the artifact name. And IMO that is bad practice to provide another
> plugin that uses the same prefix as the core plugins (like the
> maven-eclipse-plugin).
>
> Yes, it might work asis, but it is a bad practice.
>
> --jason
Re: svn commit: r528976 - in /geronimo/devtools/maven-plugins/trunk: maven-eclipse-plugin/ maven-geronimodevtools-plugin/
Posted by Jason Dillon <ja...@planet57.com>.
On Apr 15, 2007, at 3:20 PM, Sachin Patel wrote:
> These maven plugins are needed into order to build "eclipse-
> plugins". I extracted them out for use with J2G. Maven's eclipse
> plugin has made significant improvements since I initially created
> these plugins, but they still don't address many issues that are
> needed to build "eclipse plugins" or I don't like the way maven
> provides a solution to some of the issues that my plugins handle
> better.
Ya, I know the eclipse plugin has some faults. Though it would be
nice to see us not need this custom plugin and get the changes needed
merged into the official plugin. By the way, have you looked at the
pde-maven-plugin ( http://mojo.codehaus.org/pde-maven-plugin/ )?
> See...
>
> http://www.eclipse.org/articles/article.php?file=Article-Eclipse-
> and-Maven2/index.html.
>
> Also, there is no conflict with maven's eclipse plugin and this
> one. So eclipse:goal still fine.
That is not true... or I would not have mentioned it... its not like
I just started using Maven 2 yesterday :-P
Your plugin will also get bound with the prefix "eclipse" due to the
artifact name. And IMO that is bad practice to provide another
plugin that uses the same prefix as the core plugins (like the maven-
eclipse-plugin).
Yes, it might work asis, but it is a bad practice.
--jason
Re: svn commit: r528976 - in /geronimo/devtools/maven-plugins/trunk: maven-eclipse-plugin/ maven-geronimodevtools-plugin/
Posted by Sachin Patel <sp...@gmail.com>.
These maven plugins are needed into order to build "eclipse-
plugins". I extracted them out for use with J2G. Maven's eclipse
plugin has made significant improvements since I initially created
these plugins, but they still don't address many issues that are
needed to build "eclipse plugins" or I don't like the way maven
provides a solution to some of the issues that my plugins handle better.
See...
http://www.eclipse.org/articles/article.php?file=Article-Eclipse-and-
Maven2/index.html.
Also, there is no conflict with maven's eclipse plugin and this one.
So eclipse:goal still fine.
-sachin
On Apr 15, 2007, at 4:39 PM, Jason Dillon wrote:
> Yikes dude... having another maven-eclipse-plugin, or (eclipse-
> maven-plugin for that matter) is going to cause problems when one
> executes `mvn eclipse:<goal>` in a project that has these configured.
>
> And actually... why is this needed?
>
> --jason
>
>
> On Apr 15, 2007, at 6:51 AM, sppatel@apache.org wrote:
>
>> Author: sppatel
>> Date: Sun Apr 15 06:51:32 2007
>> New Revision: 528976
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=528976
>> Log:
>> rename plugin
>>
>> Added:
>> geronimo/devtools/maven-plugins/trunk/maven-eclipse-plugin/
>> - copied from r528975, geronimo/devtools/maven-plugins/trunk/
>> maven-geronimodevtools-plugin/
>> Removed:
>> geronimo/devtools/maven-plugins/trunk/maven-geronimodevtools-
>> plugin/
>>
>