Re: WWW Form Bug Report: "Can't send ErrorLog to a pipe (fix included)" on UnixWare

[Chuck Murcko <ch...@telebase.com>]

Thanks Jerry. I've forwarded this to the developer's list.

jerry@kesa.com liltingly intones:
> 
> Submitter: jerry@kesa.com
> Operating system: UnixWare, version: 
> Version of Apache Used: 1.1.1
> Extra Modules used: 
> URL exhibiting problem: 
> 
> Symptoms:
> --
> Server reported that it could not open the error
> log file when the file name begins with a "|".
> 
> NOTE: The documentation does not indicate that
>       the ErrorLog can be directed to a pipe.
>       However, examination of the http_log.c file
>       shows code to support a pipe, but the code
>       is broken.
> 
> Since TransferLog supports pipes (and because I
> want to use a program like rotatelogs for all
> of the httpd logs) I classify this as a bug.
> 
> While I suspect that the best fix would be to
> combine the code used in mod_log_common.c and
> http_log.c, I took the easy out and modified
> just http_log.c. A patch for http_log.c is
> included below.
> 
> 
> --
> 
> Backtrace:
> --
> *** http_log.c	Mon Oct 28 14:21:00 1996
> --- http_log.c.new	Mon Oct 28 14:20:38 1996
> ***************
> *** 86,95 ****
>     
>       fname = server_root_relative (p, s->error_fname);
>   
> !     if (*fname == '|') {
>         FILE *dummy;
>   
> !       spawn_child(p, error_log_child, (void *)(fname+1),
>                       kill_after_timeout, &dummy, NULL);
>   
>           if (dummy == NULL) {
> --- 86,95 ----
>     
>       fname = server_root_relative (p, s->error_fname);
>   
> !     if (*s->error_fname == '|') {
>         FILE *dummy;
>   
> !       spawn_child(p, error_log_child, (void *)(s->error_fname+1),
>                       kill_after_timeout, &dummy, NULL);
>   
>           if (dummy == NULL) {
> 
> --
> 

chuck
Chuck Murcko	N2K Inc.	Wayne PA	chuck@telebase.com
And now, on a lighter note:
Preudhomme's Law of Window Cleaning:
	It's on the other side.