You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2017/02/23 05:26:02 UTC
Review Request 56969: [ATLAS-1564] : EntityResource v1 should start
routing its calls to v2 EntityREST
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java 1ce6168
repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java 6b6ee01
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 8cad2f8
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 2f2b090
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/#review166790
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 24, 2017, 11:43 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56969/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 11:43 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1564
> https://issues.apache.org/jira/browse/ATLAS-1564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 92ea93e
> webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
>
> Diff: https://reviews.apache.org/r/56969/diff/
>
>
> Testing
> -------
>
> mvn clean package - all tests passed.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 3:43 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 92ea93e
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 3:12 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
added compact() before returning entities
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 92ea93e
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 3:08 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
addressed review comments.
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 92ea93e
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/#review166659
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java (line 236)
<https://reviews.apache.org/r/56969/#comment238688>
ctx is overwritten in every iteration. This doesn't look right. Please review.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 287)
<https://reviews.apache.org/r/56969/#comment238689>
'guid' is used to look up a type here. Isn't guid supposed to be for the entity (based on javadoc in AtlasEntityStore)? Please review.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 288)
<https://reviews.apache.org/r/56969/#comment238690>
attrName may not exist in the type. Please handle this case (to avoid NPE).
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 297)
<https://reviews.apache.org/r/56969/#comment238691>
Consider validating the value with:
attrType.isValidValue(attrValue), instead of checking for "instanceof AtlasObjectId" and "instanceof AtlasEntity" here.
It might be better to let the value validation be done by createOrUpdate() call below. This switch block should only validate the 'typeCategory'
- Madhan Neethiraj
On Feb. 24, 2017, 2:36 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56969/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 2:36 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1564
> https://issues.apache.org/jira/browse/ATLAS-1564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
> webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
>
> Diff: https://reviews.apache.org/r/56969/diff/
>
>
> Testing
> -------
>
> mvn clean package - all tests passed.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 6:36 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
updated review removing GET conversion and all other format converter changes.
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 5:06 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
repository/src/main/java/org/apache/atlas/repository/converters/AtlasArrayFormatConverter.java 9e8f523
repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java 1ce6168
repository/src/main/java/org/apache/atlas/repository/converters/AtlasEnumFormatConverter.java d71d543
repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/converters/AtlasMapFormatConverter.java bdfbf39
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
repository/src/main/java/org/apache/atlas/repository/converters/AtlasPrimitiveFormatConverter.java d0e63eb
repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java 6b6ee01
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java d7bffff
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 8cad2f8
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java fc10d07
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 2f2b090
typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 21d5f1a
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 10:26 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java 1ce6168
repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java 6b6ee01
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 8cad2f8
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 2f2b090
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 10:19 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
included classification attributes when conversion from AtlasClassification to Referenceable.
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java 1ce6168
repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java 6b6ee01
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 8cad2f8
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 2f2b090
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
> On Feb. 23, 2017, 9:14 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java, line 92
> > <https://reviews.apache.org/r/56969/diff/2/?file=1645358#file1645358line92>
> >
> > Whether to return a Referenceable or an Id should not depend on the presence of the entity in referredEntity. Referenceable should be returned only when the attribute is 'isOwnedRef=true'. In all other cases, an Id should be returned.
> >
> > It might be required to send AtlasAttribute as parameter to this method, to determine the value of isOwnedRef - from AtlasStructFormatConverter.fromV2toV1.
> >
> > Also, other 'if/else' blocks here (for v2Obj type Map and AtlasEntity) should be updated to handle this consistently.
not valid any more.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/#review166536
-----------------------------------------------------------
On Feb. 24, 2017, 3:08 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56969/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 3:08 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1564
> https://issues.apache.org/jira/browse/ATLAS-1564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 92ea93e
> webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
>
> Diff: https://reviews.apache.org/r/56969/diff/
>
>
> Testing
> -------
>
> mvn clean package - all tests passed.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/#review166536
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java (line 147)
<https://reviews.apache.org/r/56969/#comment238489>
Classification attributes will be lost in the Referenceable created below. Instead traitNames, consider passing Map<String, IStruct>.
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java (line 92)
<https://reviews.apache.org/r/56969/#comment238487>
Whether to return a Referenceable or an Id should not depend on the presence of the entity in referredEntity. Referenceable should be returned only when the attribute is 'isOwnedRef=true'. In all other cases, an Id should be returned.
It might be required to send AtlasAttribute as parameter to this method, to determine the value of isOwnedRef - from AtlasStructFormatConverter.fromV2toV1.
Also, other 'if/else' blocks here (for v2Obj type Map and AtlasEntity) should be updated to handle this consistently.
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java (line 79)
<https://reviews.apache.org/r/56969/#comment238488>
If traits/classification have attributes, wouldn't they be lost here?
Consider replacing parameter traitNames with Map<String, IStruct>, to preserve classification attributes in the Referencable instance.
- Madhan Neethiraj
On Feb. 23, 2017, 7:51 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56969/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 7:51 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1564
> https://issues.apache.org/jira/browse/ATLAS-1564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java 1ce6168
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java 6b6ee01
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 8cad2f8
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 2f2b090
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
> webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
>
> Diff: https://reviews.apache.org/r/56969/diff/
>
>
> Testing
> -------
>
> mvn clean package - all tests passed.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should
start routing its calls to v2 EntityREST
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56969/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 11:51 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1564
https://issues.apache.org/jira/browse/ATLAS-1564
Repository: atlas
Description
-------
With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST.
Diffs (updated)
-----
client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce
repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java 1ce6168
repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java 6b6ee01
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 8cad2f8
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 2f2b090
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d
webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11
Diff: https://reviews.apache.org/r/56969/diff/
Testing
-------
mvn clean package - all tests passed.
Thanks,
Sarath Subramanian