[GitHub] [ambari] eberhardtp opened a new pull request #3224: AMBARI-25548 Missing artifact at building Ambari Infra Solr Plugin (e…

[GitBox <gi...@apache.org>]

eberhardtp opened a new pull request #3224:
URL: https://github.com/apache/ambari/pull/3224


   …berhardtp)
   
   ## What changes were proposed in this pull request?
   
   Artifacts of ambari-metrics-common, ambari-serviceadvisor, ambari-views-utils, ambari-views-commons were missing during building the project.
   
   ## How was this patch tested?
   
   Build tested manually
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ambari] hapylestat commented on a change in pull request #3224: AMBARI-25548 Missing artifact at building Ambari Infra Solr Plugin (e…

[GitBox <gi...@apache.org>]

hapylestat commented on a change in pull request #3224:
URL: https://github.com/apache/ambari/pull/3224#discussion_r496281440



##########
File path: ambari-server/pom.xml
##########
@@ -1776,7 +1776,7 @@
     <dependency>
       <groupId>org.apache.ambari</groupId>
       <artifactId>ambari-serviceadvisor</artifactId>
-      <version>1.0.0.0-SNAPSHOT</version>
+      <version>${project.version}</version>

Review comment:
       this literally breaking everything, service advisor project is not connected to root project and do not aware about ${project.version}




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org