[GitHub] [incubator-seatunnel] hailin0 opened a new pull request, #2745: [Improve][Connector-V2] Fix kafka connector

[GitBox <gi...@apache.org>]

hailin0 opened a new pull request, #2745:
URL: https://github.com/apache/incubator-seatunnel/pull/2745

   * Fix SeaTunnelRow convert to json format error
   * Rename `bootstrap.server` to `bootstrap.servers` in kafka source config
   * Remove `kafka.` prefix in sink producer configuration key
   
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   Fix kafka connector
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2745: [Improve][Connector-V2] Fix kafka connector

[GitBox <gi...@apache.org>]

ashulin commented on code in PR #2745:
URL: https://github.com/apache/incubator-seatunnel/pull/2745#discussion_r972559186


##########
seatunnel-connectors-v2/connector-kafka/pom.xml:
##########
@@ -41,6 +41,11 @@
             <artifactId>kafka-clients</artifactId>
             <version>${kafka.client.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.seatunnel</groupId>
+            <artifactId>seatunnel-format-json</artifactId>
+            <version>${project.version}</version>
+        </dependency>

Review Comment:
   ```suggestion
           <dependency>
               <groupId>org.apache.seatunnel</groupId>
               <artifactId>seatunnel-format-json</artifactId>
               <version>${project.version}</version>
               <scope>provided</scope>
           </dependency>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2745: [Improve][Connector-V2] Fix kafka connector

[GitBox <gi...@apache.org>]

Hisoka-X merged PR #2745:
URL: https://github.com/apache/incubator-seatunnel/pull/2745


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org