[GitHub] [cassandra] maedhroz commented on a change in pull request #659: A raft of minor optimizations for replica filtering protection

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #659:
URL: https://github.com/apache/cassandra/pull/659#discussion_r448087497



##########
File path: src/java/org/apache/cassandra/service/DataResolver.java
##########
@@ -48,8 +48,10 @@
     private static final boolean DROP_OVERSIZED_READ_REPAIR_MUTATIONS =
         Boolean.getBoolean("cassandra.drop_oversized_readrepair_mutations");
 
+    private static final UnaryOperator<PartitionIterator> IDENTITY = UnaryOperator.identity();

Review comment:
       I think you're [right](https://stackoverflow.com/questions/23983832/is-method-reference-caching-a-good-idea-in-java-8). We shouldn't end up with multiple instances from the same call site below. In any case, I'll likely revert this if we proceed w/ the [guardrails approach|https://issues.apache.org/jira/browse/CASSANDRA-15907?focusedCommentId=17148207&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17148207].




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org