[GitHub] [spark] jose-torres commented on issue #23747: [SPARK-26848][SQL] Introduce new option to Kafka source: offset by timestamp (starting/ending)

[GitBox <gi...@apache.org>]

jose-torres commented on issue #23747: [SPARK-26848][SQL] Introduce new option to Kafka source: offset by timestamp (starting/ending)
URL: https://github.com/apache/spark/pull/23747#issuecomment-472901118
 
 
   @gaborgsomogyi, what is it that you're evaluating in depth?
   
   In general, this seems like a reasonable change. I'd make the docs more up-front about the fact that it's a pass-through feature: Spark doesn't do any interpretation or reasoning about the timestamp, it just passes it directly to Kafka for Kafka to translate into an offset. (Otherwise I worry people will get confused and think Spark is responsible for some translation problem they're facing.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org