You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/07/06 04:59:11 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2405: Charts data is mandatory for creating a fixed deposit product
josehernandezfintecheandomx opened a new pull request, #2405:
URL: https://github.com/apache/fineract/pull/2405
## Description
When creating a new fixed deposit product, charts data is not validated on the backend.
- Error when the `charts` attribute is empty or not exists
<img width="1135" alt="Screen Shot 2022-07-05 at 23 54 27" src="https://user-images.githubusercontent.com/44206706/177471999-3b1c7481-194a-4191-9a5d-2bd2ad4b2b60.png">
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2405: Charts data is mandatory for creating a fixed deposit product
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2405:
URL: https://github.com/apache/fineract/pull/2405#issuecomment-1176253870
Can you please add new test cases to verify this logic? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2405: Charts data is mandatory for creating a fixed deposit product
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2405:
URL: https://github.com/apache/fineract/pull/2405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org