You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/16 08:58:53 UTC

[GitHub] [tvm] masahi opened a new pull request, #13404: [Hexagon] Fix vrmpy tensorization

masahi opened a new pull request, #13404:
URL: https://github.com/apache/tvm/pull/13404

   Hexagon tests using `vrmpy` tensorization were broken by the change in `tir/tensor_intrin/hexagon.py` from https://github.com/apache/tvm/pull/12496. The change is a correct one from the TIR perspective, but it breaks tensorize pattern matching. Actually `T.init()` block is not necessary in a tensorize description, so just removing it fixes the breakage. 
   
   @mehrdadh 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13404: [Hexagon] Fix vrmpy tensorization

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13404:
URL: https://github.com/apache/tvm/pull/13404#issuecomment-1316632653

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Icemist, @mehrdadh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh merged pull request #13404: [Hexagon] Fix TIR vrmpy tensorization

Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #13404:
URL: https://github.com/apache/tvm/pull/13404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on pull request #13404: [Hexagon] Fix TIR vrmpy tensorization

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13404:
URL: https://github.com/apache/tvm/pull/13404#issuecomment-1319463774

   Oh thanks for the update! In TIR, formally speaking, `T.init()` should only appear strictly under `T.block()`, so we got it removed to conform to the spec


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org