[GitHub] [hadoop] dannycjones commented on a diff in pull request #4520: HADOOP-18180. Replaces ExecutorServicePool with ExecutorService

[GitBox <gi...@apache.org>]

dannycjones commented on code in PR #4520:
URL: https://github.com/apache/hadoop/pull/4520#discussion_r910945935


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -1573,7 +1560,7 @@ protected S3AReadOpContext createReadContext(
         statistics,
         statisticsContext,
         fileStatus,
-        futurePool,
+        unboundedThreadPool,

Review Comment:
   Why not the `boundedThreadPool` originally wrapped by `futurePool`?



##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AReadOpContext.java:
##########
@@ -18,10 +18,11 @@
 
 package org.apache.hadoop.fs.s3a;
 
+import java.util.concurrent.ExecutorService;

Review Comment:
   There's a `javax.annotation.Nullable` import below Apache. Can you bring it up to this import?
   
   rel: https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md#imports



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org